Prepare for preview.52 release (#988)

* Prepare for preview.52 release * Add comment explaining else if branch, fixed indentation * add another else if branch comment
Azure · Jul 6, 2023 · c39ab75 · c39ab75
1 parent e256b4d
commit c39ab75
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/packages/autorest.go/package.json b/packages/autorest.go/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@autorest/go",
-  "version": "4.0.0-preview.51",
+  "version": "4.0.0-preview.52",
   "description": "AutoRest Go Generator",
   "main": "dist/exports.js",
   "typings": "dist/exports.d.ts",

diff --git a/packages/autorest.go/src/generator/fake/servers.ts b/packages/autorest.go/src/generator/fake/servers.ts
@@ -561,6 +561,9 @@ function createParamGroupParams(clientPkg: string, op: Operation, imports: Impor
         }
         content += `\t\t${localVar}[i] = ${toType}(${fromVar})\n\t}\n`;
       } else if (param.language.go!.paramGroup) {
+        // for slices of strings that aren't in a parameter group, the call to strings.Split(...) is inlined
+        // into the invocation of the fake e.g. srv.FakeFunc(strings.Split...). but if it's grouped, then we
+        // need to create a local first which will later be copied into the param group.
         imports.add('strings');
         content += `\t${createLocalVariableName(param, 'Param')} := strings.Split(${paramValue}, "${getArraySeparator(param)}")\n`;
       }
@@ -572,11 +575,13 @@ function createParamGroupParams(clientPkg: string, op: Operation, imports: Impor
       }
       content += `\t${createLocalVariableName(param, 'Param')}, err := ${from}\n`;
       content += '\tif err != nil {\n\t\treturn nil, err\n\t}\n';
-    }  else if (param.schema.type === SchemaType.ByteArray) {
+    } else if (param.schema.type === SchemaType.ByteArray) {
       imports.add('encoding/base64');
       content += `\t${createLocalVariableName(param, 'Param')}, err := base64.StdEncoding.DecodeString(${paramValue})\n`;
       content += '\tif err != nil {\n\t\treturn nil, err\n\t}\n';
     } else if (param.language.go!.paramGroup && (param.schema.type === SchemaType.Choice || param.schema.type === SchemaType.Constant || param.schema.type === SchemaType.Duration || param.schema.type === SchemaType.SealedChoice || param.schema.type === SchemaType.String)) {
+      // for params that don't require parsing, the value is inlined into the invocation of the fake.
+      // but if it's grouped, then we need to create a local first which will later be copied into the param group.
       content += `\t${createLocalVariableName(param, 'Param')} := `;
       let paramValue = getParamValueWithCast(clientPkg, param, imports);
       if (!param.required) {