Omit read-only content from request payloads (#450)

* Omit read-only content from request payloads Add `azure:"ro"` to fields marked as read-only. Update azcore to version that supports exclusion of RO values. Enabled RO test. Added missing go.sum files. * remove go.sum files until CI is fixed
Azure · Jul 28, 2020 · f0edff7 · f0edff7
1 parent b0e2c59
commit f0edff7
Show file tree

Hide file tree

Showing 12 changed files with 611 additions and 604 deletions.
diff --git a/src/generator/gomod.ts b/src/generator/gomod.ts
@@ -16,7 +16,7 @@ export async function generateGoModFile(session: Session<CodeModel>): Promise<st
   text += 'go 1.13\n\n';
   // here we specify the minimum version of armcore/azcore as required by the code generator
   // TODO: come up with a way to get the latest minor/patch versions.
-  const azcore = 'github.com/Azure/azure-sdk-for-go/sdk/azcore v0.9.0';
+  const azcore = 'github.com/Azure/azure-sdk-for-go/sdk/azcore v0.9.2';
   if (session.model.language.go!.openApiType === 'arm') {
     text += 'require (\n';
     text += '\tgithub.com/Azure/azure-sdk-for-go/sdk/armcore v0.1.0\n';

diff --git a/src/generator/models.ts b/src/generator/models.ts
@@ -153,7 +153,11 @@ class StructDef {
           }
         }
       }
-      let tag = ` \`${this.Language.marshallingFormat}:"${serialization}"\``;
+      let readOnly = '';
+      if (prop.readOnly) {
+        readOnly = ` azure:"ro"`;
+      }
+      let tag = ` \`${this.Language.marshallingFormat}:"${serialization}"${readOnly}\``;
       // if this is a response type then omit the tag IFF the marshalling format is
       // JSON, it's a header or is the RawResponse field.  XML marshalling needs a tag.
       // also omit the tag for additionalProperties

diff --git a/test/autorest/complexgroup/readonlyproperty_test.go b/test/autorest/complexgroup/readonlyproperty_test.go
@@ -31,7 +31,6 @@ func TestReadonlypropertyGetValid(t *testing.T) {
 }
 
 func TestReadonlypropertyPutValid(t *testing.T) {
-	t.Skip("R/O NYI, test fails")
 	client := getReadonlypropertyOperations(t)
 	id, size := "1234", int32(2)
 	result, err := client.PutValid(context.Background(), complexgroup.ReadonlyObj{ID: &id, Size: &size})

diff --git a/test/autorest/generated/additionalpropsgroup/models.go b/test/autorest/generated/additionalpropsgroup/models.go
diff --git a/test/autorest/generated/complexgroup/models.go b/test/autorest/generated/complexgroup/models.go
diff --git a/test/autorest/generated/errorsgroup/models.go b/test/autorest/generated/errorsgroup/models.go
diff --git a/test/autorest/generated/lrogroup/models.go b/test/autorest/generated/lrogroup/models.go
diff --git a/test/go.mod b/test/go.mod
@@ -5,7 +5,7 @@ go 1.13
 require (
 	armnetwork v0.0.0-00010101000000-000000000000
 	azblob v0.0.0-00010101000000-000000000000
-	github.com/Azure/azure-sdk-for-go/sdk/azcore v0.9.0
+	github.com/Azure/azure-sdk-for-go/sdk/azcore v0.9.2
 	github.com/Azure/azure-sdk-for-go/sdk/to v0.1.0
 )
 

diff --git a/test/go.sum b/test/go.sum
@@ -2,7 +2,11 @@ github.com/Azure/azure-sdk-for-go/sdk/armcore v0.1.0 h1:i4/txgB7gpzLa3YBBPnSSXnR
 github.com/Azure/azure-sdk-for-go/sdk/armcore v0.1.0/go.mod h1:/cH2D+NpD2KRgnop4cU+S5P2On5mP6KWgpWq48+Bt/M=
 github.com/Azure/azure-sdk-for-go/sdk/azcore v0.9.0 h1:VdhfbVpQ3dkhXYOx/Wj1+utikcZkZSZSmpqmXWwaNJY=
 github.com/Azure/azure-sdk-for-go/sdk/azcore v0.9.0/go.mod h1:hL9TGc07RkJVzDIBxsYXC/r0M+YiRkvl4z1elXCD+8s=
+github.com/Azure/azure-sdk-for-go/sdk/azcore v0.9.2 h1:33m1ysGtf5EF8NOhH3pvVk9MfwnCQ0aGbfJelhZv1nE=
+github.com/Azure/azure-sdk-for-go/sdk/azcore v0.9.2/go.mod h1:fBbm1JLvufiabxBiiZWThNODf8+bARgZ81aP3CEx3sg=
 github.com/Azure/azure-sdk-for-go/sdk/internal v0.2.0 h1:cLpVMIkXC/umSP9DMz9I6FttDWJAsmvhpaB6MlkagGY=
 github.com/Azure/azure-sdk-for-go/sdk/internal v0.2.0/go.mod h1:Q+TCQnSr+clUU0JU+xrHZ3slYCxw17AOFdvWFpQXjAY=
+github.com/Azure/azure-sdk-for-go/sdk/internal v0.2.1 h1:xY9/wUJ8PcxmTEJ6z+0qKuj9rb3Aw9nhiL+ik5evR/g=
+github.com/Azure/azure-sdk-for-go/sdk/internal v0.2.1/go.mod h1:Q+TCQnSr+clUU0JU+xrHZ3slYCxw17AOFdvWFpQXjAY=
 github.com/Azure/azure-sdk-for-go/sdk/to v0.1.0 h1:5PmE4x8xzfL3onRdC5adQPrJSMDhYT2h5DwPB1uR9tA=
 github.com/Azure/azure-sdk-for-go/sdk/to v0.1.0/go.mod h1:UL/d4lvWAzSJUuX+19uKdN0ktyjoOyQhgY+HWNgtIYI=
diff --git a/test/network/2020-03-01/armnetwork/go.mod b/test/network/2020-03-01/armnetwork/go.mod
@@ -4,5 +4,5 @@ go 1.13
 
 require (
 	github.com/Azure/azure-sdk-for-go/sdk/armcore v0.1.0
-	github.com/Azure/azure-sdk-for-go/sdk/azcore v0.9.0
+	github.com/Azure/azure-sdk-for-go/sdk/azcore v0.9.2
 )