Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update bicep in lint-bicep to v0.31.92 #4565

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

ellismg
Copy link
Member

@ellismg ellismg commented Nov 15, 2024

The current version that is installed on the runners (0.31.34) has some bugs around linting and causes lint warnings during our legs. These errors are not present on the latest Bicep CLI.

Force an upgrade of the binary that is installed as part of the test runner to latest version. We should be able to remove this step once new image is built with an upgraded bicep (the README.md at https://github.com/actions/runner-images/tree/main/images/ubuntu has information about what is on the runner.)

@ellismg ellismg force-pushed the ellismg/fix-bicep-lint-errors branch 2 times, most recently from 8b20abe to 7060465 Compare November 15, 2024 22:41
@ellismg ellismg force-pushed the ellismg/fix-bicep-lint-errors branch 2 times, most recently from 5a3b98e to 062f68c Compare November 15, 2024 23:52
@azure-sdk
Copy link
Collaborator

Repoman Generation Results

Repoman pushed changes to remotes for the following projects:

Project: azd-starter-bicep

Remote: azure-samples-staging

Branch: pr/4565

You can initialize this project with:

azd init -t Azure-Samples/azd-starter-bicep -b pr/4565

View Changes | Compare Changes


Project: todo-csharp-cosmos-sql

Remote: azure-samples-staging

Branch: pr/4565

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/4565

View Changes | Compare Changes


Project: todo-csharp-sql-swa-func

Remote: azure-samples-staging

Branch: pr/4565

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-sql-swa-func -b pr/4565

View Changes | Compare Changes


Project: todo-csharp-sql

Remote: azure-samples-staging

Branch: pr/4565

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-sql -b pr/4565

View Changes | Compare Changes


Project: todo-java-mongo-aca

Remote: azure-samples-staging

Branch: pr/4565

You can initialize this project with:

azd init -t Azure-Samples/todo-java-mongo-aca -b pr/4565

View Changes | Compare Changes


Project: todo-java-mongo

Remote: azure-samples-staging

Branch: pr/4565

You can initialize this project with:

azd init -t Azure-Samples/todo-java-mongo -b pr/4565

View Changes | Compare Changes


Project: todo-nodejs-mongo-aca

Remote: azure-samples-staging

Branch: pr/4565

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/4565

View Changes | Compare Changes


Project: todo-nodejs-mongo-aks

Remote: azure-samples-staging

Branch: pr/4565

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-aks -b pr/4565

View Changes | Compare Changes


Project: todo-nodejs-mongo-swa-func

Remote: azure-samples-staging

Branch: pr/4565

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/4565

View Changes | Compare Changes


Project: todo-nodejs-mongo

Remote: azure-samples-staging

Branch: pr/4565

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo -b pr/4565

View Changes | Compare Changes


Project: todo-python-mongo-aca

Remote: azure-samples-staging

Branch: pr/4565

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-aca -b pr/4565

View Changes | Compare Changes


Project: todo-python-mongo-swa-func

Remote: azure-samples-staging

Branch: pr/4565

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/4565

View Changes | Compare Changes


Project: todo-python-mongo

Remote: azure-samples-staging

Branch: pr/4565

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo -b pr/4565

View Changes | Compare Changes


@ellismg ellismg force-pushed the ellismg/fix-bicep-lint-errors branch from 062f68c to 22ec5ec Compare November 15, 2024 23:57
The current version that is installed on the runners (0.31.34) has
some bugs around linting and causes lint warnings during our
legs. These errors are not present on the latest Bicep CLI.

Force an upgrade of the binary that is installed as part of the test
runner to latest version. We should be able to remove this step once
new image is built with an upgraded bicep (the `README.md` at
https://github.com/actions/runner-images/tree/main/images/ubuntu has
information about what is on the runner.)
@ellismg ellismg force-pushed the ellismg/fix-bicep-lint-errors branch from 22ec5ec to 3463553 Compare November 16, 2024 00:09
@ellismg ellismg marked this pull request as ready for review November 16, 2024 00:10
@ellismg ellismg changed the title templates: Address Bicep Lint Warnings ci: Update bicep in lint-bicep to v0.31.92 Nov 16, 2024
@ellismg
Copy link
Member Author

ellismg commented Nov 19, 2024

/check-enforcer override

@ellismg ellismg enabled auto-merge (squash) November 19, 2024 18:05
@ellismg ellismg merged commit 3818b62 into Azure:main Nov 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants