Update Samples for 3.1.0 with removing cacert.pem from Kafka Extensions #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TsuyoshiUshio
changed the title
fbeltrao
approved these changes
Aug 28, 2020
| @@ -214,36 +214,14 @@ private ConsumerConfig GetConsumerConfiguration() | |||
| conf.SaslMechanism = SaslMechanism.Plain; | |||
| conf.SaslUsername = EventHubsSaslUsername; | |||
| conf.SaslPassword = this.listenerConfiguration.EventHubConnectionString; | |||
| conf.SslCaLocation= this.EnsureValidEventHubsCertificateLocation(this.listenerConfiguration.SslCaLocation); | |||
| conf.SslCaLocation= this.listenerConfiguration.SslCaLocation; | |||
There was a problem hiding this comment.
Do we need to provide a CA for event hubs?
There was a problem hiding this comment.
Hi @fbeltrao
Thank you for the review. I think we don't need CA anymore. not only EventHubs but others.
We might be able to remove the SslCaLocation, however, there is leagacy code that cause breaking change by it and in some usecase still might use it. That is why I keep the SslCaLocation It's self. Do you have any suggestion?
There was a problem hiding this comment.
Ok. Since this is inside the block for event hubs only and we don't need a CA we could remove the line, don't we?
ryancrawcour
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the samples to the version 3.1.0
What I did
Hi @fbeltrao
Could you have a look at Microsoft.Azure.WebJobs.Extensions.Kafka.csproj , please?
Also, the KafkaListner's validation of the EventHubs with cacert validation.
I'd like to make sure if it is no problem for the customers.