Add EnableDeliveryReports to KafkaAttribute #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gliljas
force-pushed
the
EnableDeliveryReports
branch
from
42e6cf1 to
f60fb47
Compare
|
Hi @gliljas |
gliljas
force-pushed
the
EnableDeliveryReports
branch
from
f60fb47 to
00896d2
Compare
|
"Documentation" added |
gliljas
force-pushed
the
EnableDeliveryReports
branch
from
db6c1c4 to
4eef54b
Compare
ryancrawcour
previously approved these changes
Nov 18, 2020
gliljas
force-pushed
the
EnableDeliveryReports
branch
from
782b084 to
800563e
Compare
gliljas
force-pushed
the
EnableDeliveryReports
branch
2 times, most recently
from
659999e to
7aaeaa4
Compare
|
Rebased |
gliljas
force-pushed
the
EnableDeliveryReports
branch
2 times, most recently
from
f9eacfa to
58f134e
Compare
gliljas
force-pushed
the
EnableDeliveryReports
branch
from
58f134e to
72024a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to set EnableDeliveryReports is quite valuable, since the collector uses ProduceAsync behind the scenes. In high volume scenarios, the difference is huge (and the delivery reports are never exposed anyway).
Also, the MaxMessageBytes value was never properly copied.