Add ClientId configuration #191
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently, Confluent also wants it to be unique per consumergroup+client. Back to the code. |
ryancrawcour
requested review from
TsuyoshiUshio,
fbeltrao and
amamounelsayed
and removed request for
TsuyoshiUshio and
fbeltrao
|
to avoid causing a breaking change, could we ignore the clientid if not supplied? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a ClientId parameter to the KafkaTrigger. This is good thing to have, e.g for collecting metrics. In our Confluent dashboard we get this warning:
"Unable to compute throughput.
There are multiple consumers
reading from this topic that do not
have unique client IDs"
This implementation sets Dns.GetHostName() as the default value. It could be regarded as a breaking change. An option could be to wrap the INameResolver in a "SuperSpecialNameResolver", which checks the output from the wrapped resolver for special values. If you want to use Dns.GetHostName() as your client ID, you could specify e.g. "%{dns.gethostname}%" as the attribute value.