Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed edge cases in the scaling up and down #192

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Fixed edge cases in the scaling up and down #192

wants to merge 5 commits into from

Conversation

lilleman12
Copy link
Contributor

Scale in when lag is consitently below threshold and do not scale out when we increasing under the threshold

@ghost
Copy link

ghost commented Nov 10, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@lilleman12 lilleman12 changed the title ScaleDownAndUp Scale Down And Up Nov 10, 2020
@lilleman12 lilleman12 changed the title Scale Down And Up Fixed edge cases in the scaling up and down Nov 10, 2020
ryancrawcour
ryancrawcour approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@ryancrawcour ryancrawcour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryancrawcour ryancrawcour ryancrawcour approved these changes

@amamounelsayed amamounelsayed Awaiting requested review from amamounelsayed

@fbeltrao fbeltrao Awaiting requested review from fbeltrao

@TsuyoshiUshio TsuyoshiUshio Awaiting requested review from TsuyoshiUshio

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lilleman12 @ryancrawcour