Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add source to blob_trigger #196

Merged
merged 7 commits into from
May 15, 2024
Merged

Conversation

YunchuWang
Copy link
Member

@YunchuWang YunchuWang commented Dec 12, 2023

Fixes #197

Context and Problem:
Issue #197 highlighted a discrepancy in the Azure Functions documentation and the actual behavior of the BlobTrigger binding. According to the documentation, the BlobTrigger binding supports a source argument that allows setting the source of the triggering event to EventGrid for lower latency. However, in practice, the BlobTrigger binding does not currently accept this argument, and the default method for detecting changes in a blob container is through the standard polling mechanism (LogsAndContainerScan).

Objective:
This Pull Request aims to align the functionality of the BlobTrigger with the documented features by introducing the EventGrid source option. This will enable users to leverage Event Grid-based triggers for blob storage, providing a more efficient and lower-latency mechanism for blob event handling.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.11%. Comparing base (31f3d42) to head (ef5323b).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #196      +/-   ##
==========================================
+ Coverage   93.10%   93.11%   +0.01%     
==========================================
  Files          56       56              
  Lines        3247     3253       +6     
  Branches      666      666              
==========================================
+ Hits         3023     3029       +6     
  Misses        137      137              
  Partials       87       87              
Flag Coverage Δ
unittests 93.08% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YunchuWang YunchuWang self-assigned this Dec 13, 2023
@YunchuWang YunchuWang requested a review from hallvictoria as a code owner March 8, 2024 08:57
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.11%. Comparing base (b85eb7a) to head (ef5323b).
Report is 5 commits behind head on dev.

❗ Current head ef5323b differs from pull request most recent head 2a26758. Consider uploading reports for the commit 2a26758 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #196      +/-   ##
==========================================
+ Coverage   93.10%   93.11%   +0.01%     
==========================================
  Files          56       56              
  Lines        3247     3253       +6     
  Branches      666      666              
==========================================
+ Hits         3023     3029       +6     
  Misses        137      137              
  Partials       87       87              
Flag Coverage Δ
unittests 93.08% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hallvictoria hallvictoria merged commit de14772 into dev May 15, 2024
14 checks passed
@hallvictoria hallvictoria deleted the wangbill/add_blob_trigger_source branch May 15, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FeatureRequest] Add EventGrid source option for blob_trigger
3 participants