-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: enforcing unique function names #216
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallvictoria
requested review from
vrdmr,
gavin-aguiar,
YunchuWang and
pdthummar
as code owners
May 29, 2024 19:51
hallvictoria
changed the title
Enforcing unique function names
fix: enforcing unique function names
Jul 17, 2024
…-library into hallvictoria/unique-function-names
gavin-aguiar
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, functions with the same function name can be created and deployed.
For example:
This PR changes this so that the following scenarios are no longer supported. The same applies to blueprints (ie. function names must be distinct between all blueprints).
When creating an Asgi/Wsgi Function App, an integrated http function is automatically created and added. The function name here is hard-coded. In order to allow customization, the Asgi and Wsgi Function App constructors now also take in a function name. The default value is the previous value.
Fixes: Azure/azure-functions-python-worker#1489
Fixes: https://github.com/Azure/azure-functions-pyfx-planning/issues/313
Addresses ask in: Azure/azure-functions-python-worker#1422