Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGC v.2024-05-01-preview #28726

Merged
merged 24 commits into from
May 23, 2024
Merged

AGC v.2024-05-01-preview #28726

merged 24 commits into from
May 23, 2024

Conversation

malpaniHMC
Copy link
Contributor

@malpaniHMC malpaniHMC commented Apr 17, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1, Breaking Changes review

If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.

Click here to see the details of Step 2, ARM review

See https://aka.ms/azsdk/pr-arm-review.

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copy link

openapi-pipeline-app bot commented Apr 17, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Copy link

openapi-pipeline-app bot commented Apr 17, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️⚠️ azure-sdk-for-python warning [Detail]
  • ⚠️Warning in generating from 0989d917e27afde84046c1f16e7f1614ad782737. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    warn		specification/servicenetworking/ServiceNetworking.Management/tspconfig.yaml skipped due to azure-sdk-for-python not found in tspconfig.yaml
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-servicenetworking [Preview SDK Changes]
    • azure-mgmt-servicenetworking-1.0.0b1.zip
    • azure_mgmt_servicenetworking-1.0.0b1-py3-none-any.whl
    info	[Changelog] ### Features Added
    info	[Changelog]
    info	[Changelog]   - Added operation group SecurityPoliciesInterfaceOperations
    info	[Changelog]   - Model TrafficController has a new parameter security_policies
    info	[Changelog]   - Model TrafficController has a new parameter security_policy_configurations
    info	[Changelog]   - Model TrafficControllerUpdate has a new parameter security_policy_configurations
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
  • ️✔️Succeeded in generating from 0989d917e27afde84046c1f16e7f1614ad782737. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    warn		specification/servicenetworking/ServiceNetworking.Management/tspconfig.yaml skipped due to azure-sdk-for-go not found in tspconfig.yaml
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/servicenetworking/armservicenetworking [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

Copy link

openapi-pipeline-app bot commented Apr 17, 2024

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version resource-manager TypeSpec Authored with TypeSpec labels Apr 17, 2024
Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

@malpaniHMC malpaniHMC force-pushed the shmalpani/agc-2024-05-01 branch 2 times, most recently from 8287ea8 to 55592d9 Compare April 17, 2024 19:22
@AzureRestAPISpecReview AzureRestAPISpecReview removed the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Apr 18, 2024
@malpaniHMC malpaniHMC force-pushed the shmalpani/agc-2024-05-01 branch from f85565e to 086d81d Compare April 19, 2024 22:19
@AzureRestAPISpecReview AzureRestAPISpecReview added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Apr 19, 2024
@malpaniHMC malpaniHMC force-pushed the shmalpani/agc-2024-05-01 branch from 086d81d to 7b8067e Compare April 19, 2024 22:41
@AzureRestAPISpecReview AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Apr 19, 2024
@malpaniHMC malpaniHMC force-pushed the shmalpani/agc-2024-05-01 branch from 7b8067e to 5b9bd5c Compare April 19, 2024 23:11
@malpaniHMC malpaniHMC removed the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Apr 19, 2024
@malpaniHMC malpaniHMC requested a review from mikeharder April 20, 2024 00:07
@malpaniHMC malpaniHMC removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Apr 22, 2024
@openapi-workflow-bot openapi-workflow-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 22, 2024
@ramoka178
Copy link
Contributor

Please fix the failing checks that are labelled as Required.

Copy link

openapi-pipeline-app bot commented May 21, 2024

Swagger Validation Report

️❌BreakingChange: 3 Errors, 0 Warnings failed [Detail]
Compared specs (v0.10.8) new version base version
TrafficController.json 2023-11-01(a976b60) 2023-11-01(main)
Rule Message
1012 - RemovedResponseCode The new version removes the response code '200'
Old: Microsoft.ServiceNetworking/stable/2023-11-01/TrafficController.json#L370:11
1012 - RemovedResponseCode The new version removes the response code '200'
Old: Microsoft.ServiceNetworking/stable/2023-11-01/TrafficController.json#L687:11
1012 - RemovedResponseCode The new version removes the response code '200'
Old: Microsoft.ServiceNetworking/stable/2023-11-01/TrafficController.json#L1004:11
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
Compared specs (v0.10.8) new version base version
TrafficController.json 2024-05-01-preview(a976b60) 2023-11-01(main)
TrafficController.json 2024-05-01-preview(a976b60) 2023-05-01-preview(main)
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 21 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-2023-11-01 package-2023-11-01(a976b60) package-2023-11-01(main)
2024-05-01-preview 2024-05-01-preview(a976b60) default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L1045
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L1048
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L1051
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L1072
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L1095
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L1098
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L1101
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L1130
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L1148
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L1151
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L1154
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L1205
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L1227
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L1230
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L1233
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L1271
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L1289
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L1292
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L1295
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L1335
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L1658


The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L68
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L75
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L81
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L104
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L107
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L120
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L143
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L146
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L149
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L162
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L185
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L188
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L191
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L212
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L230
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L233
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L236
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L279
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L301
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L304
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L307
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L337
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L355
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L358
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L361
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L393
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L417
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L420
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L423
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json#L444
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@malpaniHMC
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@allenjzhang allenjzhang added BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 21, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview added NotReadyForARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required and removed BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 21, 2024
@malpaniHMC malpaniHMC added BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 and removed NotReadyForARMReview VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required labels May 21, 2024
@allenjzhang
Copy link
Member

@ArmReviewer. I approve adding the Version-Approved-Bugfix and BreakingChange-Approved-BugFix

@razvanbadea-msft razvanbadea-msft added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label May 22, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label May 22, 2024
@malpaniHMC
Copy link
Contributor Author

/pr RequestMerge

@razvanbadea-msft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@AzureRestAPISpecReview AzureRestAPISpecReview added VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required and removed BreakingChange-Approved-BugFix Changes are to correct the REST API definition to correctly describe service behavior labels May 23, 2024
@razvanbadea-msft razvanbadea-msft merged commit 306da47 into main May 23, 2024
31 of 32 checks passed
@razvanbadea-msft razvanbadea-msft deleted the shmalpani/agc-2024-05-01 branch May 23, 2024 06:33
Francisco-Gamino pushed a commit to Francisco-Gamino/azure-rest-api-specs that referenced this pull request Jun 5, 2024
* init

* examples ref + security config

* readme changes

* main + examples

* addressing arm review comments

* fixing validation errors from comment fixes

* remmoving ddos changes

* adding documentation and addressing warnings

* securitypolicy config !readonly + validation

* validation errors

* securityconfig array -> field

* v5 + examples

* example operation id

* readme fixes

* keeping stable version as well

* reverting 2023-11-01 changes

* adding docs for PR pipeline

* new line

* reverting

* updating to latest tsp syntax

* versioning

* removing 200s from 2023-11-01

* push

* description space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review new-api-version ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager TypeSpec Authored with TypeSpec Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.