-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AGC v.2024-05-01-preview #28726
AGC v.2024-05-01-preview #28726
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Generation Artifacts
|
Generated ApiView
|
Please address or respond to feedback from the ARM API reviewer. |
8287ea8
to
55592d9
Compare
f85565e
to
086d81d
Compare
086d81d
to
7b8067e
Compare
7b8067e
to
5b9bd5c
Compare
Please fix the failing checks that are labelled as Required. |
...source-manager/Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json
Show resolved
Hide resolved
...source-manager/Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json
Show resolved
Hide resolved
...source-manager/Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json
Show resolved
Hide resolved
...source-manager/Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json
Show resolved
Hide resolved
...source-manager/Microsoft.ServiceNetworking/preview/2024-05-01-preview/TrafficController.json
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
@ArmReviewer. I approve adding the |
/pr RequestMerge |
/azp run |
Azure Pipelines successfully started running 4 pipeline(s). |
* init * examples ref + security config * readme changes * main + examples * addressing arm review comments * fixing validation errors from comment fixes * remmoving ddos changes * adding documentation and addressing warnings * securitypolicy config !readonly + validation * validation errors * securityconfig array -> field * v5 + examples * example operation id * readme fixes * keeping stable version as well * reverting 2023-11-01 changes * adding docs for PR pipeline * new line * reverting * updating to latest tsp syntax * versioning * removing 200s from 2023-11-01 * push * description space
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.Note
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1, Breaking Changes review
If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.
Click here to see the details of Step 2, ARM review
See https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.Next Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.