Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for TokenCredentials configuration #43426

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

veinlumera
Copy link

Added support for TokenCredentials configuration for Authentication against Microsoft EntraID

fixes #43341

Basically I have fixed the issue I requested in #43341. I added a simple test but I have manually tested in against our Azure account with:

        ClientSecretCredentialBuilder()
                    .tenantId("valid tenant")
                    .clientId("valid client")
                    .clientSecret("valid secret")
                    .build();

where I created a Role Assignment (Storage Blob Data Reader), for a OIDC service principle that I used. I worked very nicely.

Also, for the test to work, I created an asset:

.assets/O1O5S5vXwx/java/sdk/storage/azure-storage-blob-nio/src/test/resources/session-records/AzureFileSystemTests.createWithTokenCredential.json

that was a copy of:

.assets/O1O5S5vXwx/java/sdk/storage/azure-storage-blob-nio/src/test/resources/session-records/AzureFileSystemTests.create[4].json

but since .assets/ directory is in .gitignore, I did not include it in the pull request

@github-actions github-actions bot added Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Storage Storage Service (Queues, Blobs, Files) labels Dec 16, 2024
Copy link

Thank you for your contribution @veinlumera! We will review the pull request and get back to you soon.

@veinlumera
Copy link
Author

veinlumera commented Dec 16, 2024 via email

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-storage-blob-nio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] Add TokenCredential auth to azure.storage.blob.nio
2 participants