Feature context and Async Filters #43435
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrm9084
requested review from
rujche,
Netyyyy,
saragluna and
moarychan
as code owners
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 5 out of 10 changed files in this pull request and generated 1 comment.
Files not reviewed (5)
- sdk/spring/spring-cloud-azure-feature-management/src/test/java/com/azure/spring/cloud/feature/management/filters/TargetingFilterTest.java: Evaluated as low risk
- sdk/spring/spring-cloud-azure-feature-management/src/test/java/com/azure/spring/cloud/feature/management/FeatureManagerTest.java: Evaluated as low risk
- sdk/spring/spring-cloud-azure-feature-management/src/main/java/com/azure/spring/cloud/feature/management/implementation/FeatureManagementConstants.java: Evaluated as low risk
- sdk/spring/spring-cloud-azure-feature-management/src/main/java/com/azure/spring/cloud/feature/management/FeatureManager.java: Evaluated as low risk
- sdk/spring/spring-cloud-azure-feature-management/src/main/java/com/azure/spring/cloud/feature/management/implementation/FeatureFilterUtils.java: Evaluated as low risk
| * @param context The context for whether or not the filter is passed. | ||
| * @return True if the feature is enabled, false otherwise. | ||
| */ | ||
| Mono<Boolean> evaluateAsync(FeatureFilterEvaluationContext context); |
There was a problem hiding this comment.
The method evaluateAsync should handle exceptions properly to avoid unhandled exceptions during feature evaluation. Consider adding documentation or handling exceptions within the method.
Suggested change
| Mono<Boolean> evaluateAsync(FeatureFilterEvaluationContext context); | |
| Mono<Boolean> evaluateAsync(FeatureFilterEvaluationContext context) throws Exception; |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds Async filters and Feature Context.
Trying to minimize the change in here #42853