Update properties description according to current doc #43447
+53
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-minh1
requested review from
weidongxu-microsoft,
haolingdong-msft,
XiaofeiCao,
ArthurMa1978,
rujche,
Netyyyy,
saragluna,
moarychan,
alzimmermsft,
srnagar,
anuchandy,
lmolkova,
vcolin7,
mssfang,
JonathanGiles and
billwert
as code owners
github-actions
bot
added
azure-spring
|
Thank you for your contribution @v-minh1! We will review the pull request and get back to you soon. |
...esourcemanager/applicationinsights/fluent/models/ApplicationInsightsComponentProperties.java
Outdated
Show resolved
Hide resolved
|
API change check API changes are not detected in this pull request. |
saragluna
requested changes
Dec 17, 2024
...esourcemanager/applicationinsights/fluent/models/ApplicationInsightsComponentProperties.java
Outdated
Show resolved
Hide resolved
sdk/core/azure-core/src/main/java/com/azure/core/util/Configuration.java
Outdated
Show resolved
Hide resolved
...xtensions/src/main/java/com/azure/identity/extensions/implementation/enums/AuthProperty.java
Outdated
Show resolved
Hide resolved
| @@ -111,41 +111,41 @@ public class AadAuthenticationProperties implements InitializingBean { | |||
| private int jwtSizeLimit = RemoteJWKSet.DEFAULT_HTTP_SIZE_LIMIT; /* bytes */ | |||
|
|
|||
| /** | |||
| * The lifespan(duration) of the cached JWK set before it expires. The default value is `5m`. | |||
| * The lifespan(duration) of the cached JWK set before it expires. | |||
There was a problem hiding this comment.
Could you help check how the The default value is 5m`` is auto-generated by the doc plugin?
| * authorization-clients.webapi.scopes[0]={WEB_API_APP_ID_URL}/WebApi.ExampleScope1, | ||
| * authorization-clients.webapi.scopes[0]={WEB_API_APP_ID_URL}/WebApi.ExampleScope2 | ||
| * '. | ||
| * The clients will be converted to OAuth2 `ClientRegistration`, the other `ClientRegistration` information(such as client id, client secret) inherits from the delegated OAuth2 login client `azure`. |
There was a problem hiding this comment.
Can we implement this in the doc plugin, so we can replace any '' in the comment, to ``
|
@microsoft-github-policy-service agree company="Microsoft" |
alzimmermsft
removed
Azure.Core
saragluna
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines