Removed most mentions of Azure from Client Core. #43455
Open
+201
−276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcolin7
added
Client
vcolin7
requested review from
samvaity,
JonathanGiles,
srnagar and
alzimmermsft
as code owners
samvaity
approved these changes
Dec 17, 2024
|
|
||
| - Configuring service clients, e.g. configuring retries, logging, etc. | ||
| - Accessing HTTP response details (`Response<T>`). | ||
| - Calling long running operations (`Poller<T>`). | ||
| - Paging and asynchronous streams (`PagedFlux<T>`). | ||
| <!-- - Calling long-running operations (`Poller<T>`). --> |
There was a problem hiding this comment.
What do you think about just removing these instead of commenting?
There was a problem hiding this comment.
Sounds good to me, I wasn't sure if we'd ever add anything related and was keeping them around just in case.
|
|
||
|  | ||
| <!--  -->~~~~ |
|
|
||
| Since these timeouts are closest to the network, if they trigger they will be propagated back through the `HttpPipeline` | ||
| and generally should be retried by the `RetryPolicy`. | ||
|
|
||
| #### HttpPipeline Timeouts | ||
|
|
||
| HttpPipeline timeouts are the next level of timeout handling the Azure SDKs provide. These timeouts are configured using | ||
| HttpPipeline timeouts are the next level of timeout handling Client Core provides. These timeouts are configured using | ||
| an `HttpPipelinePolicy` and configuring a timeout using either `Mono.timeout` for asynchronous requests or an |
There was a problem hiding this comment.
worth cleaning up the async docs in here too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also had to comment out some links in the base README due to them being tied to Azure. We'll need to come up with generic versions of those before we go GA.