-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find unused deps script and cleanup existing cruft #43456
base: main
Are you sure you want to change the base?
Conversation
This will cause a pipeline failure if there are old entries.
f465ae6
to
1e73f61
Compare
API change check API changes are not detected in this pull request. |
Pipeline experience in case of a failure:
|
13c6a6a
to
1e73f61
Compare
@Netyyyy @saragluna Lots of change in the Spring dependency listings here that I think is correct. I'd very much appreciate your input! |
@@ -119,66 +99,12 @@ testdep_net.bytebuddy:byte-buddy;1.15.5 | |||
testdep_net.bytebuddy:byte-buddy-agent;1.15.5 | |||
|
|||
## Spring boot dependency versions | |||
org.springframework.boot:spring-boot-dependencies;2.7.18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Netyyyy, will our script regenerate and append these entries here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we won't update and use these dependencies for Spring Boot2
This will find any unused lines in external_dependencies.txt and version_client.txt. It won't remove them. If it finds something it will cause a build failure.
Additionally this cleans up a handful of existing old entries that I think are no longer needed.
pom_file_version_scanner.ps1
still works, and grepping for the entries I removed didn't turn up anything that looked like it would break something.Fixes #42432