Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find unused deps script and cleanup existing cruft #43456

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

billwert
Copy link
Contributor

This will find any unused lines in external_dependencies.txt and version_client.txt. It won't remove them. If it finds something it will cause a build failure.

Additionally this cleans up a handful of existing old entries that I think are no longer needed. pom_file_version_scanner.ps1 still works, and grepping for the entries I removed didn't turn up anything that looked like it would break something.

Fixes #42432

@billwert billwert force-pushed the find-unused-deps-script branch from f465ae6 to 1e73f61 Compare December 17, 2024 22:10
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@billwert
Copy link
Contributor Author

Pipeline experience in case of a failure:

/opt/hostedtoolcache/Python/3.11.10/x64/bin/python /mnt/vss/_work/1/s/eng/versioning/find_unused_dependencies.py
Unused external_dependencies.txt entries:
  springboot3_org.testcontainers:junit-jupiter-nothere

##[error]The process '/opt/hostedtoolcache/Python/3.11.10/x64/bin/python' failed with exit code 1
Finishing: Verify version text files

@billwert billwert force-pushed the find-unused-deps-script branch from 13c6a6a to 1e73f61 Compare December 17, 2024 22:58
@billwert
Copy link
Contributor Author

@Netyyyy @saragluna Lots of change in the Spring dependency listings here that I think is correct. I'd very much appreciate your input!

@@ -119,66 +99,12 @@ testdep_net.bytebuddy:byte-buddy;1.15.5
testdep_net.bytebuddy:byte-buddy-agent;1.15.5

## Spring boot dependency versions
org.springframework.boot:spring-boot-dependencies;2.7.18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Netyyyy, will our script regenerate and append these entries here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we won't update and use these dependencies for Spring Boot2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script for cleaning up stale entries in version text files
4 participants