Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avm deployment script module and private network access #61

Open
wants to merge 77 commits into
base: main
Choose a base branch
from
Open

Avm deployment script module and private network access #61

wants to merge 77 commits into from

Conversation

sebassem
Copy link
Contributor

@sebassem sebassem commented Dec 6, 2023 •
edited
Loading

Overview/Summary

Replacing the deployment script CARML module with AVM

This PR fixes/adds/changes/removes

  1. Replaces the deployment script CARML module with AVM
  2. Replaces the resource group CARML module with AVM
  3. Replaces the userAssginedManagedIdentity CARML module with AVM
  4. Replaces the NSG CARML module with AVM
  5. Replaces the resource group CARML module with AVM
  6. Use AVM's roleAssignments code
  7. Add an "Azure login" refresh step in the workflow to avoid token expiry
  8. Deploys the deployment script in a private network
  9. Disable public access to the storage account created by the deployment script
  10. Some optimizations if the provided resource provider is not valid

Breaking Changes

N/A

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues
  • (LZ-Vending Core Team Only) Associated it with relevant ADO Items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated one or more of the following tests (if required)
  • Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)

@sebassem sebassem requested a review from a team as a code owner December 6, 2023 15:29
@sebassem sebassem marked this pull request as draft December 6, 2023 16:39
@sebassem
Delete version.json and main.bicep files for
14d1532 
storage account modules
@sebassem
Add Storage Account Management Policy module
d0ef787
@sebassem
Add Storage Account Local User module
004ac3c
@sebassem
Refactor storage account deployment in
3a4689a 
deploy.bicep
@sebassem
readme updates
980b82d
@sebassem
Delete unnecessary files
927fb37
@sebassem
Fix capitalization of headings in README files
16a931f
@sebassem
Fix resource types link and update
b3f5c37 
resourceProviders in subResourceWrapper
@sebassem
Remove unnecessary note in README.md
ff01304
@sebassem
Add storage account table, management policy,
d7a098f 
private endpoint DNS zone group, and storage
account local user deployment templates
@sebassem
Update module paths in deploy.bicep files
0d62134
@sebassem
Delete unnecessary test files
7f09797
@sebassem
Remove empty line in output section
e415f70
@sebassem
Update resource provider registration in
eb68d33 
deploy.bicep
@sebassem
Update roleDefinitionIdOrName in deploy.bicep
6f55b8d
@sebassem
Update built-in role assignments in deploy.bicep file
90d4222
@sebassem
Fix deployment script resources sub-guid length
f5fd717
@sebassem
Add 'Network Contributor' role definition
cac877e
@sebassem
Add 'Network Contributor' role assignment for resource group and subs…
81b118d 
…cription
@sebassem sebassem marked this pull request as ready for review January 14, 2024 08:38
@sebassem sebassem linked an issue Jan 14, 2024 that may be closed by this pull request
🪲 1.5.1 breaking change (maybe) #63
Closed
sebassem and others added 23 commits January 16, 2024 10:23
@sebassem
Delete version.json and deploy.parameters.json files
b6e8d73
@sebassem
Remove commented out code and update resourceProviders in deploy.bicep
be1e8d5
@sebassem
Fix error handling in Get-AzRoleAssignment
727417d
@sebassem
Remove version.json and update managed identity module
eb0a20f
@sebassem
use virtual-network avm module
53528bb
@sebassem
remove dc carml module
aee3f61
@sebassem
Delete version.json files for storage account modules
7c32401
@sebassem
Remove private-endpoint version.json and private-dns-zone-group files
70904fb
@sebassem
Update RBAC role assignments
880ae88
@sebassem
Update builtInRoleNames variable in deploy.bicep files
175d0bb
@sebassem
Update deploy.bicep to set userAssignedResourcesIds to null
8c25c87
@sebassem
Add deploymentScriptLocation parameter to main.bicep
8ac06bf
@sebassem
Add deploymentScriptLocation parameter
5d122a8
@sebassem
Remove resourceProviders from lz-vending and vwanSpoke modules
950cf6e
@sebassem
Refactor deployment script variables and add resourceProviders to hub…
103d2ca 
…Spoke and vwanSpoke modules
@sebassem
Update deployment script resource names with unique identifiers
dd677c4
@sebassem
Update deployment script resource group name
3e6b279
@sebassem
Add resource providers for Microsoft.HybridCompute and Microsoft.AVS
b776c8c
@sebassem
Update deployment script resource group and name with sub-guid
3c65cc3
@sebassem
Remove resource providers from test files
3262244
@sebassem
Remove empty line in deploy.bicep
0c25c3f
@sebassem @jtracey93
AAD Renames (#62) (#66)
a45f223 
* aad renames

* Update consumer guide

Co-authored-by: Jack Tracey <[email protected]>
@sebassem
Refactor deploy.bicep file by removing unnecessary code
78c3000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🪲 1.5.1 breaking change (maybe)
1 participant
@sebassem