-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: avm/res/compute/gallery
: Added UDT applicationsType
#3817
feat: avm/res/compute/gallery
: Added UDT applicationsType
#3817
Conversation
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
Important If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs). To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label! The core team will only review and approve PRs that have this label applied! |
avm/res/compute/gallery
: Added UDT applicationsTypeavm/res/compute/gallery
: Added UDT applicationsType
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution. I added some small comments.
Thanks! Implemented the comments. Could you re-check it to see if it's as expected? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your contribution.
For next time, please do not solve conversations. Usually, the reviewer does that after checking again. This makes it easier for us to do the reviews on many modules at the same time.
Hey @ReneHezser, I'll leave the final approval to you as you reviewed the PR initially :) |
@ReneHezser Let me know if I have to do something 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the contribution.
@johnlokerse You can merge the PR now. Thanks for your patience. |
@AlexanderSehr or @ReneHezser Can you merge it for me? I am just a contributor ;-) |
Say no more @johnlokerse |
Description
This PR adds the
applicationsType
UDT and updates existing UDTs to follow AVM standards.Tagging owner: @ReneHezser
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.