Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: avm/res/compute/gallery: Added UDT applicationsType #3817

Merged
merged 17 commits into from
Dec 9, 2024

Conversation

johnlokerse
Copy link
Contributor

@johnlokerse johnlokerse commented Nov 20, 2024

Description

This PR adds the applicationsType UDT and updates existing UDTs to follow AVM standards.

Tagging owner: @ReneHezser

Pipeline Reference

Pipeline
avm.res.compute.gallery

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@johnlokerse johnlokerse requested review from a team as code owners November 20, 2024 13:00
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Nov 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Nov 20, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Nov 20, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@johnlokerse johnlokerse changed the title avm/res/compute/gallery: Added UDT applicationsType feat: avm/res/compute/gallery: Added UDT applicationsType Nov 20, 2024
@ReneHezser ReneHezser self-assigned this Nov 20, 2024
Copy link
Contributor

@ReneHezser ReneHezser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. I added some small comments.

avm/res/compute/gallery/application/main.bicep Outdated Show resolved Hide resolved
avm/res/compute/gallery/main.bicep Outdated Show resolved Hide resolved
@ReneHezser ReneHezser removed the Needs: Triage 🔍 Maintainers need to triage still label Nov 20, 2024
@johnlokerse
Copy link
Contributor Author

Thank you for your contribution. I added some small comments.

Thanks! Implemented the comments. Could you re-check it to see if it's as expected?

ReneHezser
ReneHezser previously approved these changes Nov 20, 2024
Copy link
Contributor

@ReneHezser ReneHezser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your contribution.

For next time, please do not solve conversations. Usually, the reviewer does that after checking again. This makes it easier for us to do the reviews on many modules at the same time.

@AlexanderSehr
Copy link
Contributor

Hey @ReneHezser, I'll leave the final approval to you as you reviewed the PR initially :)

@johnlokerse
Copy link
Contributor Author

@ReneHezser Let me know if I have to do something 😃

Copy link
Contributor

@ReneHezser ReneHezser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the contribution.

@ReneHezser
Copy link
Contributor

@johnlokerse You can merge the PR now. Thanks for your patience.

@johnlokerse
Copy link
Contributor Author

@AlexanderSehr or @ReneHezser Can you merge it for me? I am just a contributor ;-)

@AlexanderSehr AlexanderSehr merged commit 6be7016 into Azure:main Dec 9, 2024
4 checks passed
@AlexanderSehr
Copy link
Contributor

Say no more @johnlokerse

@johnlokerse johnlokerse deleted the johnlokerse/udt-compute-gallery branch December 9, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants