Add table, Support multiply boards and slide them periodly #11
Conversation
There was a problem hiding this comment.
Thanks for the contribution!
I have some reviews that need you to follow, please let me know if you have any questions.
And please remember to reference the issue number (like #10 for this one) in the description of your Pull Request.
src/app/app.module.ts
Outdated
| import { ElModule } from 'element-angular' | ||
|
|
||
| // if you use webpack, import style | ||
| import 'element-angular/theme/index.css' |
There was a problem hiding this comment.
Could we only include the css in the component files?
Because I do not think include css into app.module.ts is a good idea.
There was a problem hiding this comment.
ok,I will amend as soon as possible
| title: string, | ||
| type: string, | ||
| data: Array<Array<string | number | {}>>, | ||
| roles: Array<{ type: string, role: string }>, |
There was a problem hiding this comment.
Please keep the original format: vertical align the :, thanks.
There was a problem hiding this comment.
Thanks for following my reviews.
I'd like to merge your PR after you make the CI(Continous Integration) green by making sure your new code can be able to pass all the automatic tests.
Current it had failed: see the result at https://travis-ci.com/BUPT/cad-board/builds/91834721
You can reproduce the test result by run npm test locally.
BTW: Please also add the issue number to track the issue at the description of this PR.
|
Great to see your update because it seems that you had fixed the linting issues. However, there's still some problem with the angular unit tests, please fix them as well. |
|
I think the test case should be modified, When we use setInternal () to support multiply boards and sliding them periodly, the test case will say timeout,and test case can't pass. Could you give me some advice?Thanks. |
|
@linyimin-bupt It seems that you had run into issues #1 Please also have a look at: angular/protractor#4300 (comment) and angular/angularfire#779 Hope those informations will be helpful. |
Add repeat function
No description provided.