Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a flat beecoin source for admins. #12001

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Tsar-Salat
Copy link
Contributor

@Tsar-Salat Tsar-Salat commented Dec 7, 2024

About The Pull Request

A client having the R_ADMIN permissions at roundend will give a flat 250 beecoins.

Why It's Good For The Game

Basically, the only way we have metacoin increases for clients is through the roundend counter or achievements.

The first of which only considers playtime as a character in-round. The detriment of this is that choosing to administrate a round over playing ingame is actively a detriment to getting cool stuff as admin in the beeshop.

My solution isn't the perfect solution, but I think the value reaches about around where normal playing is at round conclusion (~200 beecoins).

I brought this up in an admin meeting and was told that it was a code issue, so here I am.

Testing Photographs and Procedure

Screenshots&Videos

Screenshot 2024-12-07 184350

Changelog

🆑
server: admins get a flat beecoin amount at roundend, around what players get for surviving a station and escaping to centcom.
/:cl:

@WhereAmO
Copy link
Contributor

WhereAmO commented Dec 8, 2024

gimme antag tokens instead

@Tsar-Salat
Copy link
Contributor Author

gimme antag tokens instead

damn-door-spiderman

@llol111
Copy link
Contributor

llol111 commented Dec 8, 2024

i dont see why this would need to be a thing, i think admins should admin because they want to not for anything else
but i guess i dont have a problem with it either if maints things it a good idea

@Tsar-Salat
Copy link
Contributor Author

Tsar-Salat commented Dec 8, 2024

i think admins should admin because they want to not for anything else

This isnt a reward. This is just about equal to what playing the round does.

I wrote this in the PR body. C'mon man.

Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is equal to 9 hours of play in a single round, admins already get donator perms and this will be granted regardless of if they are playing or idling.

The max value should be like 30 and ot should only be rewarded if any amount of tickets were resolved in a round.

code/__DEFINES/metacoin.dm Outdated Show resolved Hide resolved
@Tsar-Salat
Copy link
Contributor Author

Tsar-Salat commented Dec 8, 2024

This is equal to 9 hours of play in a single round, admins already get donator perms and this will be granted regardless of if they are playing or idling.

The max value should be like 30 and ot should only be rewarded if any amount of tickets were resolved in a round.

Oh I didnt know the modifier was that severe.

The playtime modifier codedoc says its 4 every 10 minutes. Thats +24 every hour played alive and +20 if escaping onto centcom. About equal to two or 3 rounds of play.

The admin flat is a bit too high. I lowered it.

@Geatish
Copy link
Contributor

Geatish commented Dec 10, 2024

Do mods get anything? 👉👈

@PowerfulBacon
Copy link
Member

I don't think that admins should be able to get points this way since it is a method of obtaining beecoins inaccessible to regular players. It would be very unfair if an admin even came close to being top of the beecoin leaderboard (since nobody actually uses them for buying things anyway) and admins already get donator rewards

@PowerfulBacon PowerfulBacon added the 🔑 Close Key (1/3) Indicates that someone has requested this PR to be keyed label Dec 12, 2024
@Tsar-Salat
Copy link
Contributor Author

Tsar-Salat commented Dec 12, 2024

This doesn't reference a thing I said.

It would be very unfair if an admin even came close to being top of the beecoin leaderboard

You're worried about the optics of obscure leaderboards when those with DB access set their beecoin amounts to funny numbers to get a laugh when you check their playerinfo?

No one is getting big dick energy from an arbitrary number on a leaderboard. C'mon man.

(since nobody actually uses them for buying things anyway)

...No one uses the coins that are meant to be used for buying stuff in the bee shop... At all?

I don't know how to engage with that. Why else would I care about the silly DB number at all????

admins already get donator rewards

I'm going to assume you mean the 10 meme items in the beecoin shop, and not the "rewards" of admins not having to worry about being kicked out when they join the server past popcap when joining to answer a ticket.

I don't understand what part of my rationale you disagree with.

If there's a better solution or the number is too high or anything I am always willing the change it. This was just the simplest I dea I could think of.

I honest to God just wanted to try out the new colorizers that got added in the last 2 years.

@Tsar-Salat
Copy link
Contributor Author

Please I really am hoping you are amicable to working this out. This isn't an ideal solution, but I think my reason for this is solid.

If you have an idea on how I can improve this please patch me in.

Im not looking for reward as an admin, or for contributing my time.
I want to see this place thrive and I would not put my self interest in front of that, I've talked with other admins and I thought adding the end of round ghost to try and meet around the value that players got was a reasonable idea.

@PowerfulBacon
Copy link
Member

I don't necessarily disagree with the stated points in the PR body, but I have my own thoughts that I don't think we're covered.

Players not being able to access it can be kind of resolved by calling the bonus to only applying if you are under 10k coins.

The bigger issue is determining what the player is actually doing. If they don't actually answer tickets, they shouldn't get coins. If they play the game at any point, they shouldn't get bonus coins even if they ghost. If implemented then I could see bugs being reported when an admin didn't get coins after spawning themselves in, but if not implemented it will be abused accidentally by just getting coins without playing the game.

I don't personally think that spending a round adminning should be comparable to actually playing the round in terms of playtime rewards, since it's not playing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔑 Close Key (1/3) Indicates that someone has requested this PR to be keyed Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants