Remove dependency on PHPUnit #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
|
|
||
| "require-dev": { | ||
| "symfony/process": "~2.1", | ||
| "silex/silex": "~1" | ||
| "silex/silex": "~1", | ||
| "phpunit/phpunit": "~4.0" |
There was a problem hiding this comment.
why is there a dev depending on it ?
There was a problem hiding this comment.
I haven't removed assertions from features/bootstrap/FeatureContext.php, though they would be simple to replace.
|
👍 |
|
@stof Here is anything to be done here for this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix #37.
It should behave the same, except that the equals check in
theResponseShouldContainJsonis a lot more naive.