Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history 
Change type from `Int8` to `UInt8` for efficiency.

Co-authored-by: Jakob Nybo Nissen <[email protected]>
  • Loading branch information
@CiaranOMara @jakobnissen
CiaranOMara and jakobnissen committed Jul 1, 2022
1 parent 7414bb4 commit 6d96e79
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/submat.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -156,12 +156,12 @@ end

# Return the row/column index of `nt`.
function index(nt::BioSymbols.NucleicAcid)
return reinterpret(Int8, nt)
return reinterpret(UInt8, nt)
end

# Return the row/column index of `aa`.
function index(aa::BioSymbols.AminoAcid)
return reinterpret(Int8, aa) + 1
return reinterpret(UInt8, aa) + 1
end


Expand Down

2 comments on commit 6d96e79

@CiaranOMara
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/63800

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v2.2.0 -m "<description of version>" 6d96e79d7a518f28a83f42de7c59b90f25f63eec
git push origin v2.2.0

Please sign in to comment.