Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Bump + Default Port Scan Timeout Change #113

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Conversation

rvazarkar
Copy link
Contributor

Description

Bumps commonlib with new fixes

Ups our default port scan timeout to 10000ms. During testing we discovered that the task scheduler is not "fair" and can often result in false positives in the port scanner if set lower.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

chore: bump commonlib version
chore: bump version
@rvazarkar rvazarkar merged commit b3bba2c into 2.X Sep 3, 2024
1 check passed
@rvazarkar rvazarkar deleted the version_bump branch September 3, 2024 16:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants