-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release workflow to github, pypi, and docker hub #10
Conversation
- bump docker/build-push-action to v6 - add annotations metadata entry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the awesome work! Just a few comments
Not sure if we want to do it in this PR or after the first pypi release, but we should include the pip install instructions on the README |
probably do a follow-up pr after a pypi release is made |
- add a simple changelog to github release - run docker/pypi release after gh release as gh release workflow creates a new branch
I've set the required repo secrets for dockerhub personal access token |
- [github] fix unmatched single quotes
- [github] Fix git log cmd when generating changelog: branch not yet created
Created trusted publisher on pypi |
- [github] change git log format
version 0.2.24 Update pyproject.toml
- [gh] cleanup
- [gh] fix pr run condition
- [gh] fix release condition
Included pr workflow |
- [gh] remove the redundant assignment to `tag`
- fix docker tags for pr - [docker] cleanup
[gh] cleanup: correct annotation position
Prob last build, just to test whether everything is working
done in 62aa290 |
Good to merge at your discretion |
all things on the TODO list have been done, you can merge it now |
Closes #2
Examples (released by 81becb3):
Known limitations:
Features:
pull_request
trigger. To push the image, trigger the workflow manually withworkflow_dispatch
PR todos:
Docker meta
step is necessary. Probably generate with shell instead.to deploy this workflow file to this repo:
project.name
back to normal inplugin/pyproject.toml
(needs changes in the repo)project.version
to the normal one inplugin/pyproject.toml
(needs changes in the repo)DOCKERHUB_USERNAME
(docker hub username) andDOCKERHUB_TOKEN
(docker hub password)to make a new release:
project.version
inplugin/pyproject.toml
Code References: