Use 'is [not] null' instead of ==/!=

[satano]

Summary by CodeRabbit

• Refactor

  • Modernized null checks across various files to use is not null syntax for improved readability and consistency.

• Chores

  • Updated import statements and their order in multiple files for better organization and compliance with new standards.

[update-docs]

Thanks for opening this pull request! If you have implemented new functions, write about them in the readme file.

[coderabbitai]

Walkthrough

The updates across several files involve transitioning from traditional != null checks to the modern is not null syntax for improved readability and alignment with contemporary C# practices. Additionally, there are import optimizations and order adjustments in some files, with the inclusion of specific Microsoft OpenAPI imports where necessary.

Changes

Files/Directories	Change Summary
demo/OrderService/...	Updated SwaggerDefaultValues.cs to use Microsoft.OpenApi.Models and revised null checks to is not null.
demo/ProjectService/...	Modified null check from project != null to project is not null in ProjectsService.cs.
src/MMLib.SwaggerForOcelot/...	Changed multiple source files to update null checks from != null to is not null and modified import statements for swashbuckle and openapi.
tests/MMLib.SwaggerForOcelot/...	Replaced parameters != null with parameters is not null in AggregateRouteDocumentationGeneratorShould.cs.

Poem

In the code paths deep, where logic flows,
A rabbit hopped with nimble toes.
From != to is not, it turned the way,
Modern C# shines, clears the day.
Imports danced in ordered line,
Code refined, a grand design.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[request-info]

We would appreciate it if you could provide us with more info about this issue/pr!

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ecc9644 and c5722b3.

Files selected for processing (11)

• demo/OrderService/SwaggerDefaultValues.cs (4 hunks)
• demo/ProjectService/Controllers/ProjectsService.cs (1 hunks)
• src/MMLib.SwaggerForOcelot/Aggregates/AggregateRouteDocumentationGenerator.cs (2 hunks)
• src/MMLib.SwaggerForOcelot/Aggregates/RouteDocs.cs (2 hunks)
• src/MMLib.SwaggerForOcelot/Aggregates/RoutesDocumentationProvider.cs (2 hunks)
• src/MMLib.SwaggerForOcelot/Configuration/SwaggerEndPointOptions.cs (2 hunks)
• src/MMLib.SwaggerForOcelot/Middleware/SwaggerForOcelotMiddleware.cs (3 hunks)
• src/MMLib.SwaggerForOcelot/RouteOptionsExtensions.cs (1 hunks)
• src/MMLib.SwaggerForOcelot/ServiceDiscovery/SwaggerServiceDiscoveryProvider.cs (3 hunks)
• src/MMLib.SwaggerForOcelot/Transformation/SwaggerJsonTransformer.cs (5 hunks)
• tests/MMLib.SwaggerForOcelot.Tests/Aggregates/AggregateRouteDocumentationGeneratorShould.cs (2 hunks)

Files skipped from review due to trivial changes (4)

• src/MMLib.SwaggerForOcelot/Aggregates/AggregateRouteDocumentationGenerator.cs
• src/MMLib.SwaggerForOcelot/Aggregates/RoutesDocumentationProvider.cs
• src/MMLib.SwaggerForOcelot/ServiceDiscovery/SwaggerServiceDiscoveryProvider.cs
• tests/MMLib.SwaggerForOcelot.Tests/Aggregates/AggregateRouteDocumentationGeneratorShould.cs

Additional comments not posted (19)

demo/OrderService/SwaggerDefaultValues.cs (3)

26-28: Good practice! Modern null check syntax.

The null check for operation.Parameters using is null improves readability and aligns with modern C# practices.

---

37-39: Good practice! Modern null check syntax.

The null check for parameter.Description using is null improves readability and aligns with modern C# practices.

---

42-44: Good practice! Modern null check syntax.

The null check for parameter.Default using is null improves readability and aligns with modern C# practices.

src/MMLib.SwaggerForOcelot/Configuration/SwaggerEndPointOptions.cs (1)

62-62: Good practice! Modern null check syntax.

The null check for Config using is not null improves readability and aligns with modern C# practices.

demo/ProjectService/Controllers/ProjectsService.cs (1)

54-56: Good practice! Modern null check syntax.

The null check for project using is not null improves readability and aligns with modern C# practices.

src/MMLib.SwaggerForOcelot/RouteOptionsExtensions.cs (1)

28-28: Good practice! Modern null check syntax.

The null check for UpstreamHttpMethod using is not null improves readability and aligns with modern C# practices.

src/MMLib.SwaggerForOcelot/Aggregates/RouteDocs.cs (3)

60-60: LGTM! Modern null check.

The null check update to is not null is consistent with modern C# practices.

---

68-68: LGTM! Nested null check update.

The nested null check update to is not null is consistent with modern C# practices.

---

144-144: LGTM! Modern null check.

The null check update to is not null is consistent with modern C# practices.

src/MMLib.SwaggerForOcelot/Middleware/SwaggerForOcelotMiddleware.cs (4)

74-74: LGTM! Modern null check.

The null check update to is not null is consistent with modern C# practices.

---

140-140: LGTM! Modern null check.

The null check update to is not null is consistent with modern C# practices.

---

146-146: LGTM! Modern null check.

The null check update to is not null is consistent with modern C# practices.

---

151-151: LGTM! Modern null check.

The null check update to is not null is consistent with modern C# practices.

src/MMLib.SwaggerForOcelot/Transformation/SwaggerJsonTransformer.cs (6)

89-89: LGTM! Modern null check.

The null check update to is not null is consistent with modern C# practices.

---

103-103: LGTM! Modern null check.

The null check update to is not null is consistent with modern C# practices.

---

139-139: LGTM! Modern null check.

The null check update to is not null is consistent with modern C# practices.

---

144-144: LGTM! Modern null check.

The null check update to is not null is consistent with modern C# practices.

---

157-157: LGTM! Modern null check.

The null check update to is not null is consistent with modern C# practices.

---

351-351: LGTM! Modern null check.

The null check update to is not null is consistent with modern C# practices.