MEGA pull request + NEW improvements. Lets breathe new life into this project! #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the original work of @psolyca at BusPirate#133 - I just expanded this change to be repo-wide. Co-authored-by: Damien Gaignon <[email protected]> Signed-off-by: Mike Banon <[email protected]>
Based on the original work of @endolith at BusPirate#136 - I also filled the colors for Bus Pirate v4. Co-authored-by: endolith <[email protected]> Signed-off-by: Mike Banon <[email protected]>
Based on the original work of @wmpluto at BusPirate#149 - I have reviewed this commit and believe it is OK. Co-authored-by: Pluto <[email protected]> Signed-off-by: Mike Banon <[email protected]>
Based on the original work of @marsfan at BusPirate#156 - I have improved this .gitignore further. Co-authored-by: Gabriel R. <[email protected]> Signed-off-by: Mike Banon <[email protected]>
Based on the original work of @mpasternacki at BusPirate#158 - I have reviewed this commit and believe it is OK. Co-authored-by: Maciej Pasternacki <[email protected]> Signed-off-by: Mike Banon <[email protected]>
Based on the original work of @drechc at BusPirate#160 1) add single byte address options 2) allow values like FF AA BB, in addition to 0xFF 0xAA 0xBB 3) correct chip address range 4) add comments - Although I have not tested this commit, I believe it is OK. Also did a few tab/spaces replacements (more to follow later). Co-authored-by: Corey Drechsler <[email protected]> Signed-off-by: Mike Banon <[email protected]>
Based on the original work of @cimarronm at BusPirate#164 - I have reviewed this commit and believe it is OK. Co-authored-by: Cimarron Mittelsteadt <[email protected]> Signed-off-by: Mike Banon <[email protected]>
Based on the original work of @denis2342 at BusPirate#169 - I have reviewed this commit and believe it is OK. Also improved the ifdef, works fine both for v3 and v4. Co-authored-by: denis2342 <[email protected]> Signed-off-by: Mike Banon <[email protected]>
Based on the original work of @psolyca at BusPirate#173 - I have reviewed this commit and believe it is OK. Also improved the ifdef, works fine both for v3 and v4. Co-authored-by: Damien Gaignon <[email protected]> Signed-off-by: Mike Banon <[email protected]>
To ensure the successful builds on high optimization levels, we need to add the volatile keyword to these variables declarations. NOTE: these errors happen with XC16 v2.10 and may go away later. Signed-off-by: Mike Banon <[email protected]>
These settings often go out-of-sync with the latest MPLAB X versions, are polluting the diffs and make it harder to edit/analyze these XMLs. So lets remove: if they are needed, your MPLAB X will re-generate them. Signed-off-by: Mike Banon <[email protected]>
This is required to avoid the errors at the latest MPLAB X. Signed-off-by: Mike Banon <[email protected]>
The serious opensource development - especially related to the opensource firmware / hardware - is mostly done on Linux nowadays. Signed-off-by: Mike Banon <[email protected]>
This is needed to estimate the internal memory consumption of a chip. Signed-off-by: Mike Banon <[email protected]>
The serious opensource development - especially related to the opensource firmware / hardware - is mostly done on Linux nowadays. Signed-off-by: Mike Banon <[email protected]>
This simplifies the project configs and does not break anything. Signed-off-by: Mike Banon <[email protected]>
This commit fixes the path of .map file at configurations.xml Signed-off-by: Mike Banon <[email protected]>
Needed to ensure the clean code contributions to our embedded project. Signed-off-by: Mike Banon <[email protected]>
Set up the optimized memory models - where we could get away with it on all the optimization settings of the selected project/configuration. NOTE: the different settings for v3/v4 firmwares are as intended; v4 has more features enabled, so is bigger and its build fails on small models. Signed-off-by: Mike Banon <[email protected]>
This change could make the debugging slightly easier. Signed-off-by: Mike Banon <[email protected]>
This change could make the debugging slightly easier. Signed-off-by: Mike Banon <[email protected]>
This change could make the debugging slightly easier. Signed-off-by: Mike Banon <[email protected]>
Needed to ensure the clean code contributions to our embedded project. gnu99 = c99 + extensions like asm() (is required for some projects). Signed-off-by: Mike Banon <[email protected]>
This change could make the debugging slightly easier. Signed-off-by: Mike Banon <[email protected]>
This change could make the debugging slightly easier. Signed-off-by: Mike Banon <[email protected]>
This could help us to reduce the internal memory consumption of a chip. Signed-off-by: Mike Banon <[email protected]>
This change could make the debugging slightly easier. Signed-off-by: Mike Banon <[email protected]>
Needed to ensure the clean code contributions to our embedded project. Signed-off-by: Mike Banon <[email protected]>
This change could make the debugging slightly easier. Signed-off-by: Mike Banon <[email protected]>
This file does not exist and is not required for the successful builds. Signed-off-by: Mike Banon <[email protected]>
Needed to ensure the successful build of firmware-STK500v2. Signed-off-by: Mike Banon <[email protected]>
The new supported way of these configurations - is using a bunch of Signed-off-by: Mike Banon <[email protected]>
Needed to ensure their successful builds. Signed-off-by: Mike Banon <[email protected]>
Needed to ensure the successful builds of this firmware. Signed-off-by: Mike Banon <[email protected]>
Add a missing include and replace the deprecated _CONFIG usage. Signed-off-by: Mike Banon <[email protected]>
Needed to simplify the navigation/etc at command-line terminal emulator. Signed-off-by: Mike Banon <[email protected]>
|
Thank you. Wasn't aware that MPLABX was at version 6.35? Are you sure you didnt mean V6.15? I've just downloaded V6.20 today. Do these changes apply to V4 of the bus pirate hardware? |
|
@djsbriscoe Yes, I'm using v6.15 - thank you for noticing a typo! Need some time to re-test on v6.20 but should be fine too, btw the projects will auto-upgrade in a new MPLAB X. These commits help both v3 and v4; mine is v4 but I care about v3 too! |
|
@denis2342 Hi there Denis! Thank you for your interest and extra improvements for Bus Pirate V4 source code. Please, could you share your further BPv4 source code modifications that you have described on your DangerousPrototypes forum page ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have looked through the existing open pull requests, merged some of them - with edits where necessary! - and also did a couple dozen of my own commits to ensure the successful builds of all the projects by the latest MPLAB X v6.15 + XC16 v2.10
Co-authors mentioned at commit messages:
Also,