fix: update abortcontroller/abortSignal for use in Reactive Native #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes auth_token from reporting update tests
no access to React Native, instead tested for existence of AbortSignal.timeout, if there, use it; otherwise, use a general timeout on the AbortController should fix #92 fixes test
courcelan
force-pushed
the
2530-fix-react-native-support-timeout-issue
branch
from
b111808 to
758172b
Compare
marcinpece-apptension
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Tests passed https://share.zight.com/X6ujx5Q4
https://share.zight.com/xQuJKOo4
I can't test on React Native either. I checked if it work in general on browser
LGTM 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no access to React Native, instead tested for existence of AbortSignal.timeout,
if there, use it; otherwise, use a general timeout on the AbortController
fix for #92