-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BFD-2906: Automate Maven Release Process #2061
BFD-2906: Automate Maven Release Process #2061
Conversation
ad74599
to
6aa57e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and verified in GHA. 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After discussion with @mjburling today (I will allow him to summarize in a comment, etc...) I'm ok with this moving forward within the context provided by that forthcoming comment.
Is updating the documentation for our release process included in this story, or is it recorded somewhere? |
We could probably include that as part of the follow-up Story, BFD-2907. This Story is specifically for getting the Workflow created -- BFD-2907 is the part where we actually integrate this new Workflow into our release process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work!
…ow steps into Build Release workflow
…ions; update github actions IAM Role to include appropriate policies
.github/workflows/build-release.yml
Outdated
CA_DATA_DICTIONARY_ASSETS: | | ||
[ | ||
"bfd-server-war-${{ inputs.releaseVersion }}-v1-data-dictionary.csv", | ||
"bfd-server-war-${{ inputs.releaseVersion }}-v2-data-dictionary.csv", | ||
"bfd-server-war-${{ inputs.releaseVersion }}-v1-data-dictionary.json", | ||
"bfd-server-war-${{ inputs.releaseVersion }}-v2-data-dictionary.json" | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is going to need some additional attention, post #2065
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated this to include the new .xlsx
Excel worksheet and to follow the updated naming conventions introduced in #2065. That should be enough, but let me know if I missed something.
7a6ad9b
to
c497d17
Compare
c497d17
to
af9d3a5
Compare
…FD-3048; include dd xlsx as part of release assets
Co-authored-by: Brian Burton <[email protected]> Co-authored-by: Michael J Burling <[email protected]>
Co-authored-by: Brian Burton <[email protected]> Co-authored-by: Michael J Burling <[email protected]>
Co-authored-by: Brian Burton <[email protected]> Co-authored-by: Michael J Burling <[email protected]>
JIRA Ticket:
BFD-2906
User Story or Bug Summary:
As a BFD engineer I want to be able to have an automated release process that uses the maven release plugin to push build artifacts to CodeArtifact and ECR.
What Does This PR Do?
NOTE: This PR is being merged into an intermediate branch as additional changes are required before this process is usable
This PR:
Build Release
that can be started manually (seeworkflow_dispatch
).pom.xml
pom.xml
s to the version specified by the operatorpom.xml
s on the branch specified by the operator (master
, in the typical case), and create a tag from this commit with the release version as the tag namepom.xml
s again setting their versions to the development version specified by the operator (typically<releaseVersion + 1>-SNAPSHOT
)SNAPSHOT
pom.xml
s on the branch specified (usuallymaster
)bfd-mgmt
repository, versioned appropriatelybfd-release
GitHub Application, which is configured to bypass branch protection rules onmaster
bfd-data-*
modules to be included as part of the parentpom.xml
so that they are versioned and built similarly to all other modulesThis PR has been validated by:
Build Release
workflow against a protected branch, verifying that the workflow runs successfully, all Git operations succeed (and protections are bypassed), all artifacts are uploaded to their respective repositories, and a corresponding GitHub Release is generated with the appropriate data dictionary files appended as assetsterraform plan
ning the changes tomgmt
, verifying that the plan does not include any unexpected changes and that all changes are validNo changes to our infrastructure have been made as of this PR. I will apply
mgmt
when this PR is merged.What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
What Security Implications Does This PR Have?
Submitters should complete the following questionnaire:
If the answer to any of the questions below is Yes, then you must supply a link to the associated Security Impact Assessment (SIA), security checklist, or other similar document in Confluence here: N/A
If the answer to any of the questions below is Yes, then please add @StewGoin as a reviewer, and note that this PR should not be merged unless/until he also approves it.
What Needs to Be Merged and Deployed Before this PR?
This PR cannot be either merged or deployed until the following prerequisite changes have been fully deployed:
master
are converted to equivalent rules using Rulesets, with thebfd-release
GitHub Application exempted from those rulesetsSubmitter Checklist
I have gone through and verified that...:
BFD-123: Adds foo
README
updates and changelog / release notes entries.TODO
and/orFIXME
comments, which include a JIRA ticket ID for any items that require urgent attention.