BFD-3625: Add gitleaks to build-release #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dondevun
previously approved these changes
Sep 5, 2024
sb-benohe
previously approved these changes
Sep 5, 2024
|
Security Approved! |
dondevun
approved these changes
Sep 5, 2024
mjburling
requested review from
meliGuzman,
aschey-forpeople and
malessi
as code owners
aschey-forpeople
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-3625
What Does This PR Do?
This effectively installs
gitleaksfrom the latest gitleaks/gitleaks release archive inside the build-release workflow.While
gitleaksitself is MIT licensed, the official gitleaks action appears to require a free license when executing as part of a GitHub organization. I don't believe this flouts any specific licenses at issues as I've simply implemented a step to download/install the MIT-licensed gitleaks archive–I'd just rather not go through any additional steps to allow gitleaks executions to proceed as part of the build-release workflow.What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependencies
Modifies any security controls
Adds new transmission or storage of data
Any other changes that could possibly affect security?
I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe) approval.)Validation
Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.
I'm running the build-release workflow on the branch that backs this PR–
it's already beyond the✅ Success!gitleaksstep, but I'll be keeping this in draft until I've removed the automated commits from the history.