BFD-3517: Duplicate GET Locust test suites with POST #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahiFentaye
requested review from
mjburling,
dondevun,
meliGuzman,
aschey-forpeople and
malessi
as code owners
|
@MahiFentaye Please use a little more verbosity with the PR template. |
BFD-3517_duplicate-POST-Locust-test-suites updating hashed to unhashed
MahiFentaye
force-pushed
the
BFD-3517_duplicate-POST-Locust-test-suites
branch
from
fde5885
to
7567282
Compare
|
@MahiFentaye I think this looks good. Have you tested it? |
|
yes, I have tested @dondevun |
dondevun
previously approved these changes
Sep 17, 2024
mjburling
changed the title
aschey-forpeople
approved these changes
Sep 17, 2024
aschey-forpeople
requested changes
Sep 17, 2024
mjburling
reviewed
Sep 17, 2024
|
I think we also need to update |
…that aren't used anymore adding the new regression post test suit ti app.py BFD-3517_duplicate-POST-Locust-test-suites removing added post tests that aren't used anymore adding the new regression post test suit ti app.py
MahiFentaye
force-pushed
the
BFD-3517_duplicate-POST-Locust-test-suites
branch
5 times, most recently
from
1667eb1
to
20d3b65
Compare
…ries add post high_volume_suite BFD-3517_duplicate-POST-Locust-test-suites remove unused test and queries add post high_volume_suite
MahiFentaye
force-pushed
the
BFD-3517_duplicate-POST-Locust-test-suites
branch
from
20d3b65
to
67b8de3
Compare
dondevun
reviewed
Oct 1, 2024
correcting name
dondevun
approved these changes
Oct 1, 2024
malessi
approved these changes
Oct 1, 2024
aschey-forpeople
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-3517
What Does This PR Do?
BFD-3517_duplicate POST Locust test suites
adds
post_by_urlmethod that takes abodyparameterwhen
bodyis present, it will make aPOSTrequest instead of aGETThere is a copy of each test suit to a new POST version
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependencies
Modifies any security controls
Adds new transmission or storage of data
Any other changes that could possibly affect security?
I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe) approval.)Validation
Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.
This has been tested against test db
locust -f v2/regression_suite_post.py --users 10 --spawn-rate 10 --spawned-runtime 30s
locust -f v1/regression_suite_post.py --users 10 --spawn-rate 10 --spawned-runtime 30s
locust -f high_volume_suite_post.py --users 10 --spawn-rate 10 --spawned-runtime 30s