Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFD-3684: Some processes are failing to run as they reference old BFD Server database parameters #2455

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

malessi
Copy link
Contributor

@malessi malessi commented Oct 2, 2024

JIRA Ticket:
BFD-3684

What Does This PR Do?

This PR updates old references to two BFD Server DB-related SSM parameters in various Python scripts used by Lambdas and other processes; most importantly, this fixes the Regression Suite.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies

  • Modifies any security controls

  • Adds new transmission or storage of data

  • Any other changes that could possibly affect security?

  • I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (@sb-benohe) approval.)

Validation

Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.

  • Searching the repository for data_server_db_username and data_server_db_password, verifying that there are no further code usages
  • Using the aws ssm CLI to pull each new parameter, verifying that the path is correct and a value is returned

@malessi malessi enabled auto-merge (squash) October 2, 2024 21:47
@malessi malessi merged commit 923aaf8 into master Oct 3, 2024
8 checks passed
@malessi malessi deleted the alessio/BFD-3684__fix-invalid-db-parameters branch October 3, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants