jimfuqian/BB2-3133-Fix-Insights-Lambda-Updates-Athena-Metrics-Tables-python-scripts #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Fix-Lambda-Updates-Athena-Metrics-Table
JFU-NAVA-PBC
requested review from
mjburling,
dondevun,
meliGuzman,
aschey-forpeople and
malessi
as code owners
aschey-forpeople
approved these changes
Oct 3, 2024
…Fix-Lambda-Updates-Athena-Metrics-Table
dondevun
deleted the
jimfuqian/BB2-3133-Fix-Lambda-Updates-Athena-Metrics-Table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BB2-3133
What Does This PR Do?
Fix table column parsing logic to handle boolean type.
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependencies
Modifies any security controls
Adds new transmission or storage of data
Any other changes that could possibly affect security?
I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe) approval.)Validation
run terraform plan and verify the output with reference to the README about the expected result (per README there are some known 'noises' in the terraform plan which are Ok...)
if result looks good, proceed to terraform apply (to the LLE, sandbox) and verify the fix, e.g. check out the quicksight per app dashboard for the visual result.