BFD-3745: Force UTC everywhere #2498
Open
+224
−188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -145,8 +148,8 @@ args="" | |||
| [[ $use_minio == "true" ]] && args="$args -Ds3.local=true" | |||
| [[ $projects != "" ]] && args="$args$projects" | |||
| [[ $include_dependencies = "true" ]] && args="$args -am" | |||
| [[ $test_arg != "" ]] && args="$args -Dtest=\"$test_arg\"" | |||
| [[ $it_test_arg != "" ]] && args="$args -Dit.test=\"$it_test_arg\"" | |||
| [[ $test_arg != "" ]] && args="$args -Dtest=$test_arg" | |||
There was a problem hiding this comment.
All the changes besides setting the timezone are things shellcheck was complaining about
| @@ -219,7 +224,6 @@ if [[ $install = "true" ]] ; then | |||
| jar_file=${exec_dir}/${app_name}.jar | |||
| [[ -r $jar_file ]] && rm -f $jar_file | |||
| [[ -d $lib_dir ]] && rm -rf $lib_dir | |||
| [[ -r $run_script ]] && rm -f $run_script | |||
There was a problem hiding this comment.
Removed because $run_script doesn't exist
| @@ -252,11 +256,6 @@ if [[ x$kubernetes = xtrue ]] ; then | |||
| echo ERROR: unable to find kubernetes resource files in $kubernetes_root 1>&2 | |||
| exit 1 | |||
| fi | |||
| if [[ $run_mode = "rif" ]] ; then | |||
There was a problem hiding this comment.
Removed because $run_mode doesn't exist. Looks like this was copy/paste error from the pipeline script.
aschey-forpeople
requested review from
mjburling,
dondevun and
malessi
as code owners
dondevun
reviewed
Nov 22, 2024
dondevun
previously approved these changes
Nov 25, 2024
timothy-ellis-ky
previously approved these changes
Nov 26, 2024
aschey-forpeople
dismissed stale reviews from timothy-ellis-ky and dondevun
via
5cb81a5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-3745
What Does This PR Do?
This change sets
TZ=UTCeverywhere we launch a JVM process to ensure consistency with date operations. Notably this fixes the following issues:_lastUpdatedparameter without specifying a timezone, it currently defaults to the server timezone which could produce unexpected resultsWhat Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependencies
Modifies any security controls
Adds new transmission or storage of data
Any other changes that could possibly affect security?
I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe) approval.)Validation
Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.
Tested the server locally and in an ephemeral environment to ensure the setting took effect.