Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

un-anchored :hover issue #387

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

un-anchored :hover issue #387

wants to merge 17 commits into from

Conversation

niallmur
Copy link

This is an extension to work already carried out by hpbuniat.
#116
However the rule he submitted did not work correctly and threw parser errors when there was a null before :hover
This basic check below threw a cant read a null from text error.
div.test :hover{
}

This rule is important because it can cause very severe performance issues in IE7 if :hover is used and un-anchored.

(bug report about un-anchored hovers in IE7 and IE8)
https://developers.google.com/speed/docs/best-practices/rendering
http://msdn.microsoft.com/en-us/library/ie/cc848866%28v=vs.85%29.aspx

brettstimmerman and others added 8 commits September 9, 2012 18:11
This is an extension of work carried out by hpbuniat. The rule he submitted did not work if there was a null before :hover.
This rule tests for the IE7/IE8 issue where un-anchored hovers cause poor performance
@stubbornella
Copy link
Member

This looks good, can you add documentation on the wiki in the rules section?

@niallmur
Copy link
Author

niallmur commented Jun 6, 2013

Hi,
I have added some documentation to the rules sections of the wiki in https://github.com/niallmur/csslint-1/wiki/Rules and https://github.com/niallmur/csslint-1/wiki/Avoid-un-anchored-hovers

Would you like me to also make the same updates to with wiki in stubbornella / csslint?

@stubbornella
Copy link
Member

Yes, please. I like this rule. Let's try to get it into the next version.

On Thu, Jun 6, 2013 at 1:57 AM, niallmur [email protected] wrote:

Hi,
I have added some documentation to the rules sections of the wiki in
https://github.com/niallmur/csslint-1/wiki/Rules.
Would you like me to also make the same updates to with wiki in
stubbornella / csslint?


Reply to this email directly or view it on GitHubhttps://github.com//pull/387#issuecomment-19032637
.

id: "non-link-hover",
name: "Non-Link Hover",
desc: "Using :hover pseudo-selector to non-link elements is known to be slow.",
browsers: "IE",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be IE7, IE8

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated affected browsers to IE7, IE8

@stubbornella
Copy link
Member

Overall, this looks great, just a couple things to clean up. Thanks!

@niallmur
Copy link
Author

Hi Nicole,

I have made all the changes you asked for.
-removed extra file
-edited the affected browsers
-editied the rule comment
-added a more complicated test case

I have however managed to kick off a merge to 'duplicate property value
pairs...' not sure how to cancel this

Thanks

Niall

On Wed, Jun 12, 2013 at 8:12 AM, Nicole Sullivan
[email protected]:

Overall, this looks great, just a couple things to clean up. Thanks!


Reply to this email directly or view it on GitHubhttps://github.com//pull/387#issuecomment-19309992
.

niallmur added 3 commits June 18, 2013 14:51
…this is against convention this is still valid css and wll prevent the :hover performance issue
@nschonni nschonni added the Rule label Apr 2, 2014
@nschonni nschonni added this to the 0.11.0 milestone Apr 2, 2014
@nschonni nschonni added the Triage label Apr 2, 2014
@XhmikosR XhmikosR removed this from the 0.11.0 milestone Jan 9, 2016
@XhmikosR XhmikosR modified the milestones: 1.0.0, 0.11.0 Jan 9, 2016
@XhmikosR
Copy link
Member

XhmikosR commented Jan 9, 2016

Can you clean up the branch? Rebase, squash etc.

@XhmikosR XhmikosR modified the milestone: 1.0.0 Jul 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants