Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional changes to StokesMOST #97

Merged
merged 4 commits into from
Oct 12, 2024
Merged

Additional changes to StokesMOST #97

merged 4 commits into from
Oct 12, 2024

Commits on Oct 11, 2024

  1. Initial updates from W. Large 

    Bill's source mods were based on a slightly older version of CVMix, so I
created a temporary branch from where I believe he started his work and copied
his changes in. Then I merged master in, resulting in this version of
cvmix_kpp.F90
    @mnlevy1981
    mnlevy1981 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    ca365e3 View commit details
    Browse the repository at this point in the history

  2. Cv -> CVt2 (and settable parameter) 

    I created a new CVt2 component to the kpp parameter type, it is set to 2.6 by
default during initialization but users can change it by calling

cvmix_put_kpp('CVt2', new_val)

after calling cvmix_init_kpp()
    @mnlevy1981
    mnlevy1981 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    da50e0b View commit details
    Browse the repository at this point in the history

  3. Clean up white-space 

    Noticed an if statement was removed (so code inside block always ran), but the
existing code was not unindented
    @mnlevy1981
    mnlevy1981 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    dcae106 View commit details
    Browse the repository at this point in the history

  4. Change gfortran compile flags 

    gfortran now compiles with same flags CESM uses when DEBUG=TRUE, except I added
-Werror to elevate warnings to errors and then also turned on
-Wno-maybe-uninitialized to avoid failing tests because the compiler thinks
there's a chance we are accessing uninitialized memory (the one failure caught
by this in CI was initializing an allocatable array element-by-element inside a
loop: this was a false-positive, as the loop covered all indices)
    @mnlevy1981
    mnlevy1981 committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    5fb6230 View commit details
    Browse the repository at this point in the history