Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of WhosOnline #297

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

DanielWTQ
Copy link
Contributor

The REL1_39 version has broken SQL, the fix for which (T328852) was only added to the master branch at the time. While it is available on the REL1_40 branch now, I believe it is preferable to use the master branch rather than a release-specific branch that is different from the targeted release (1.39).

Clone the (current) latest version of the master branch to include subsequent localization updates and other improvements since we are upgrading anyway.

The REL1_39 version has broken SQL, the fix for which (T328852) was only added
to the master branch at the time. While it is available on the REL1_40 branch
now, I believe it is preferable to use the master branch rather than a
release-specific branch that is different from the targeted release (1.39).

Clone the (current) latest version of the master branch to include subsequent
localization updates and other improvements since we are upgrading anyway.
@DanielWTQ
Copy link
Contributor Author

Hmm, the pushing failed?

#94 exporting to image
#94 pushing layers 0.8s done
#94 ERROR: failed to push ghcr.io/canastawiki/canasta:1.39.1-20230914-297: unexpected status from POST request to https://ghcr.io/v2/canastawiki/canasta/blobs/uploads/: 403 Forbidden
------
 > exporting to image:
------
ERROR: failed to solve: failed to push ghcr.io/canastawiki/canasta:1.39.1-20230914-297: unexpected status from POST request to https://ghcr.io/v2/canastawiki/canasta/blobs/uploads/: 403 Forbidden
Error: buildx failed with: ERROR: failed to solve: failed to push ghcr.io/canastawiki/canasta:1.39.1-20230914-297: unexpected status from POST request to https://ghcr.io/v2/canastawiki/canasta/blobs/uploads/: 403 Forbidden

@yaronkoren
Copy link
Member

Looks good to me! That "403 forbidden" error always happens when someone who doesn't have developer rights on this repo (or any of the other Canasta repos) creates a pull request. I assume there's some setting to fix this problem, but I don't know what it is.

@yaronkoren yaronkoren changed the title Update cloned version of WhosOnline Update version of WhosOnline Sep 14, 2023
@yaronkoren yaronkoren merged commit 61ffc09 into CanastaWiki:master Sep 14, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants