Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades MsUpload to newer version [METHW-177] #331

Merged
merged 5 commits into from
Dec 7, 2023
Merged

Conversation

vedmaka
Copy link
Collaborator

@vedmaka vedmaka commented Nov 30, 2023

Commit 8c2403b09186f5f25f0c28369e6aff3c285047df
Fixes #333

@yaronkoren
Copy link
Member

@vedmaka - clearly there are still a few issues with the code; but can you explain why this upgrade is needed?

Copy link

🐳 The image based on 804803ad commit has been built with 1.39.1-20231130-331 tag as ghcr.io/canastawiki/canasta:1.39.1-20231130-331

@vedmaka
Copy link
Collaborator Author

vedmaka commented Nov 30, 2023

@yaronkoren I have added details to #333

@vedmaka vedmaka requested a review from yaronkoren November 30, 2023 17:11
@yaronkoren
Copy link
Member

@vedmaka - yes, thank you. By the way, for the code - most of the Git fetches that get the latest code include a "--single-branch -b master". I just wanted to note that; it probably doesn't really matter either way.

@yaronkoren yaronkoren merged commit cff172d into master Dec 7, 2023
2 checks passed
jeffw16 pushed a commit that referenced this pull request Dec 11, 2023
* Upgrades MsUpload to newer version

Commit `8c2403b09186f5f25f0c28369e6aff3c285047df`

* Fixes a branch name for MsUpload

* Fixes branch for the MsUpload

* Fixes commit typo

* Reverts accidental MobileFrontend commit change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MsUpload issues
2 participants