feat: Cap Apps + Custom S3 Config functionality #181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various updates to improve the desktop application, particularly around S3 configuration and user interface enhancements. The most significant changes include the addition of S3 configuration management, updates to the settings interface, and improvements to error handling and user feedback.
S3 Configuration Management:
S3ConfigPage
component to manage S3 configuration settings, including form fields for provider, access key ID, secret access key, endpoint, bucket name, and region.ensure_defaults
method inS3UploadMeta
to set default values for AWS region and bucket if not provided.get_s3_config
function to callensure_defaults
on the S3 configuration object.Settings Interface Enhancements:
Error Handling and User Feedback:
check_upgraded_and_update
function to suggest signing out and back in if the plan update fails.delete_auth_open_signin
function to correctly wait for the main window to close before proceeding.Miscellaneous:
DATABASE_ENCRYPTION_KEY
to.env.example
for encrypting sensitive data in the database.position_traffic_lights_impl
function to handle errors when getting the native window handle.