Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cap Apps + Custom S3 Config functionality #181

Merged
merged 8 commits into from
Nov 23, 2024
Merged

Conversation

richiemcilroy
Copy link
Collaborator

@richiemcilroy richiemcilroy commented Nov 22, 2024

This pull request includes various updates to improve the desktop application, particularly around S3 configuration and user interface enhancements. The most significant changes include the addition of S3 configuration management, updates to the settings interface, and improvements to error handling and user feedback.

S3 Configuration Management:

  • Added a new S3ConfigPage component to manage S3 configuration settings, including form fields for provider, access key ID, secret access key, endpoint, bucket name, and region.
  • Introduced ensure_defaults method in S3UploadMeta to set default values for AWS region and bucket if not provided.
  • Enhanced get_s3_config function to call ensure_defaults on the S3 configuration object.

Settings Interface Enhancements:

  • Added a new "Cap Apps" section in the settings menu to navigate to the new S3 configuration page. [1] [2]
  • Updated the general settings to include a "Cap Pro" badge for pro features and adjusted the labels for pro-specific settings. [1] [2]

Error Handling and User Feedback:

  • Improved error message in check_upgraded_and_update function to suggest signing out and back in if the plan update fails.
  • Fixed a logical error in delete_auth_open_signin function to correctly wait for the main window to close before proceeding.

Miscellaneous:

  • Added DATABASE_ENCRYPTION_KEY to .env.example for encrypting sensitive data in the database.
  • Updated position_traffic_lights_impl function to handle errors when getting the native window handle.

Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cap-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2024 8:04pm

@richiemcilroy richiemcilroy merged commit 11079ae into main Nov 23, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant