wip - do not merge #145
Open
wip - do not merge #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqk
force-pushed
the
ak.wip-seconds_relative
branch
from
2aa3dc5
to
a1b38f1
Compare
aqk
force-pushed
the
ak.wip-seconds_relative
branch
from
a1b38f1
to
505e52a
Compare
arvidn
reviewed
Mar 6, 2023
| @@ -637,7 +659,7 @@ pub fn parse_conditions( | |||
| } else { | |||
| spend.before_seconds_relative = Some(s); | |||
| } | |||
| if s <= spend.seconds_relative { | |||
| if Some(s) <= spend.seconds_relative { | |||
There was a problem hiding this comment.
I don't think this works. I believe any Some(...) value will compare greater than None
|
Can this be closed now? |
1 similar comment
|
Can this be closed now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.