Add support for Google optional authorization parameters. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup functions to remove unneeded parameters
…ng the optional parameters in the constructed URL.
|
Silly issue: the initialization function being used isn't available on some platforms. Adding one additional parameter can fix it. I'm going to attempt to add a commit that does that... |
|
Is everything all good? |
|
Yup everything is good. I've never pushed a commit to someone else's branch as part of a PR before. But it worked! Thanks again for this, great change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Google optional parameters:
login_hint: Suggest Google account email address to perform authorization withinclude_granted_scopes: Include previously granted scopes in the authorization request.Fix
Remove unused parameters in the
LoginProviderandRefreshProviderTests
Add new tests to ensure
AuthorizationURLis properly constructed