Bring -e|--env args in line with docker
#487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
October 8, 2020 07:15
able to share in /root/.circleci because Docker for Mac. Just use Vagrant.
Error: failed to start event processor: failed to compute task config: failed to read config file: read /tmp/local_build_config.yml: is a directory
Codecov Report
@@ Coverage Diff @@
## master #487 +/- ##
==========================================
- Coverage 26.84% 26.82% -0.02%
==========================================
Files 35 35
Lines 4739 4764 +25
==========================================
+ Hits 1272 1278 +6
- Misses 3341 3356 +15
- Partials 126 130 +4
Continue to review full report at Codecov.
|
|
Let me know whether there's interest in merging this and I'll try to fix up the code coverage. |
|
Ping. :) |
|
Ping on this. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #473
This closes the gap between how
docker run -e|--envandcircleci local execute -e|--envbehaves. Now, as indocker run, bare-e|--env VARarguments are resolved from the local environment and passed on topicardproperly. Arguments that are fully specified are never resolved from the environment and arguments are still required to be passed in order to forward them on topicard(i.e. there isn't any automatic inclusion of the environment in thepicardarguments).I'm happy to spin out the Vagrantfile if that's not welcome just yet but rather than figuring out to get Docker for Mac and golang set up on my MacBook I figured I'd just make an environment that anyone can benefit from.
Obviously I'd like to clean up the commits prior to merge but I wanted to get the discussion going.