-
Notifications
You must be signed in to change notification settings - Fork 27
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: add when parameter to all commands (#56)
* feat: add 'when' parameter to all commands In order to use the common `when` command parameter in an orb command, the orb command needs to have its own `when` parameter. Here I'm adding `when` to each command so that `on_success`, `on_fail` or `always` can be plumbed through. This is useful in circumstances where you may need to, say, install the Github CLI as part of the steps taken after a CI failure. Example circleci.yml: ```yaml commands: build-failure-pr-comment: steps: - gh/setup: when: on_fail - run: gh pr comment ... when: on_fail ``` * fix: update deployment test by fixing macos tests and adding more recent uubuntu images --------- Co-authored-by: Jason Young <[email protected]>
- Loading branch information
1 parent
e89b4c5
commit a8b7461
Showing
4 changed files
with
40 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters