Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, nice library, thank you for taking the time to do the low level register stuff, it's saved me some frustration :).
I noticed that in the write_string function, you pass the contents of the RGB struct in GRB order to the write(R,G,B) function:
Nano_Every_WS2812B/src/Nano_Every_WS2812B.cpp
Line 75 in 832af0a
isn't this a double re-ordering (because the write() function expects (r,g,b) input, and writes the data as (g,r,b) to the LED):
Nano_Every_WS2812B/src/Nano_Every_WS2812B.cpp
Lines 62 to 67 in 832af0a