Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better story for library version compatibility #127

Open
gmethvin opened this issue Jan 14, 2020 · 3 comments
Open

Better story for library version compatibility #127

gmethvin opened this issue Jan 14, 2020 · 3 comments

Comments

@gmethvin
Copy link
Collaborator

gmethvin commented Jan 14, 2020

At the moment we introduce breaking library changes in patch versions, which can create pretty significant disruption for users. It's great to keep libraries up to date, but if pulsar4s upgrades a library (e.g. play-json or Akka) when upgrading to a patch version that's means I either need to upgrade the library or risk binary incompatibility issues in my project. It seems like we might need different branches for different library versions, and/or a more conservative approach to upgrading libraries.

@sksamuel
Copy link
Contributor

sksamuel commented Jan 14, 2020 via email

@gmethvin
Copy link
Collaborator Author

I actually think we can be more conservative than that if possible. For example Akka 2.6.x is backwards compatible with 2.5.x (assuming no use of deprecated APIs). So if we continue to depend on 2.5.x, our library will work for both 2.5.x and 2.6.x users, but if we upgrade to 2.6.x, we're cutting off Akka 2.5.x users for no good reason. There's no reason for pulsar4s to upgrade its Akka to 2.6.x until we need to make use of Akka 2.6.x features.

@sksamuel
Copy link
Contributor

sksamuel commented Jan 24, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants