Use Try for ConsumerMessage value #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmethvin
force-pushed
the
consumer-message-try
branch
2 times, most recently
from
3bed06f to
128695d
Compare
gmethvin
force-pushed
the
consumer-message-try
branch
from
128695d to
d6037b8
Compare
|
I also went ahead and reverted some library versions based on our discussion in #127. |
sksamuel
approved these changes
Feb 1, 2020
| @@ -7,15 +7,15 @@ travisBuildNumber in Global := sys.env.getOrElse("TRAVIS_BUILD_NUMBER", "0") | |||
| def travisVersion(v: String, tb: String): String = v.stripSuffix("-SNAPSHOT") + s".$tb-SNAPSHOT" | |||
|
|
|||
| val org = "com.sksamuel.pulsar4s" | |||
| val AkkaStreamVersion = "2.6.1" | |||
| val AkkaStreamVersion = "2.5.28" // compatible with Akka 2.5.x and 2.6.x | |||
| @@ -18,6 +18,8 @@ trait ConsumerMessage[T] { | |||
|
|
|||
| def value: T | |||
|
|
|||
| def valueTry = Try(value) | |||
There was a problem hiding this comment.
I slightly prefer the Try naming since it's clear what it is. There are many reasons why something might be "safe" or "unsafe".
|
Ok.
…On Sun, 2 Feb 2020, 23:56 Greg Methvin, ***@***.***> wrote:
Merged #133 <#133> into master.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#133>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFVSGS7NHTCUZDAAK5JKS3RA6WX5ANCNFSM4KNPJ2YQ>
.
|
|
@sksamuel can we do a new release for this? |
|
yep, will do tonight.
…On Mon, 3 Feb 2020 at 12:49, Greg Methvin ***@***.***> wrote:
@sksamuel <https://github.com/sksamuel> can we do a new release for this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#133>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFVSGS5MNI2BD5EUZ4L6GDRBBRM5ANCNFSM4KNPJ2YQ>
.
|
|
alright thanks! |
|
2.4.6 is up on maven
…On Tue, 4 Feb 2020 at 16:03, Greg Methvin ***@***.***> wrote:
alright thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#133>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFVSGQU7VMFZSJSGRWG4U3RBHQ4LANCNFSM4KNPJ2YQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
ConsumerMessageinstances to be able to represent a Pulsar message whose value cannot be parsed. This brings the behavior roughly in line with the Java client, which will allow you to create messages with invalid data but will throw whengetValueis called. It also prevents the Akka streams source from failing immediately upon creating theConsumerMessage, allowing the user code to decide how to handle the error.