-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test 1M EDMF (diag and prog) on GPU #3070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No we don't have to keep the 1M one. Why does this change make it work on GPU?
You mean you want to keep the 0M in the GPU CI? Not the 1M? I think it would be good to have 1M tests on the GPU. Maybe we can add both then? For diagnostic edmf we had to flatten the detrainment function signature to pass less things in. For prognostic edmf it's a bug in ClimaCore. Once it's fixed I should be able to use the normal fill (i.e. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Also, it's possible that this additional entrainment
method may not even be needed after CliMA/ClimaCore.jl#1782 🤞🏻. That said, I think it's a good idea to merge this before that
Sorry that was a typo (I was replying while explaining edmf equations to others lol). I meant we don't need to keep the 0M one. |
6574750
to
cfb4e89
Compare
cfb4e89
to
be14eef
Compare
This PR makes EDMFX (prognostic and diagnostic) work with 1M microphysics on the GPU. Thank you @charleskawczynski !
@szy21 - I wasn't sure if you would like to also keep the 0M edmf aquaplanet runs in the CI?