Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow select input for comparison value on Checkbox #400

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Oct 7, 2024

Summary

Register select input as a comparison value for the Checkbox in the Condition tab.

Will affect visual aspect of the product

NO

Screenshots

2024-10-07_12-20-16.mp4

Test instructions

  • Create a Checkbox to use as a Condition.
  • Create another field and set a condition based on the value of the created Checkbox.
  • Check if it works like in the video attached.

Check before Pull Request is ready:

Closes #398

@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review October 7, 2024 09:24
@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Oct 7, 2024 that may be closed by this pull request
@pirate-bot
Copy link
Contributor

Plugin build for bcec227 is ready 🛎️!

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Oct 7, 2024
@selul selul merged commit 70f26f2 into development Oct 7, 2024
7 checks passed
@selul selul deleted the fix/checkbox-condition-checking branch October 7, 2024 09:55
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 33.0.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added released Indicate that an issue has been resolved and released in a particular version of the product. pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conditional Logic Not Working with Checkbox Selection
3 participants