fix (#4) : 알고리즘 오류 수정 , dday 잘못계산

CodingWasabi · Apr 12, 2022 · ef673e0 · ef673e0
1 parent 51eb8bf
commit ef673e0
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 11 deletions.
diff --git a/src/main/java/com/codingwasabi/howtodo/web/exam/entity/Exam.java b/src/main/java/com/codingwasabi/howtodo/web/exam/entity/Exam.java
@@ -11,6 +11,7 @@
 import javax.persistence.OneToOne;
 
 import com.codingwasabi.howtodo.web.account.entity.Account;
+import com.codingwasabi.howtodo.web.policy.util.DateProcessor;
 
 import lombok.Builder;
 import lombok.Getter;
@@ -44,8 +45,7 @@ private Exam(Account account, String name, LocalDateTime dueDateTime, int studyD
 	}
 
 	public int getDDay(LocalDate today) {
-		return today.until(dueDateTime.toLocalDate())
-					.getDays();
+		return DateProcessor.calculateDDay(today, dueDateTime.toLocalDate());
 	}
 
 	public boolean isMid() {

diff --git a/src/main/java/com/codingwasabi/howtodo/web/policy/planMaking/MonthPlanMakingPolicy.java b/src/main/java/com/codingwasabi/howtodo/web/policy/planMaking/MonthPlanMakingPolicy.java
@@ -1,6 +1,6 @@
 package com.codingwasabi.howtodo.web.policy.planMaking;
 
-import static com.codingwasabi.howtodo.web.policy.util.ExamDateSorting.*;
+import static com.codingwasabi.howtodo.web.policy.util.DateProcessor.*;
 
 import java.time.LocalDate;
 import java.time.temporal.ChronoUnit;

diff --git a/src/main/java/com/codingwasabi/howtodo/web/policy/tendency/MostChosenTendencySolution.java b/src/main/java/com/codingwasabi/howtodo/web/policy/tendency/MostChosenTendencySolution.java
@@ -1,6 +1,6 @@
 package com.codingwasabi.howtodo.web.policy.tendency;
 
-import static com.codingwasabi.howtodo.web.policy.util.ExamDateSorting.*;
+import static com.codingwasabi.howtodo.web.policy.util.DateProcessor.*;
 
 import java.time.LocalDate;
 import java.util.Collections;
@@ -121,16 +121,15 @@ private boolean everyExamHasIntervalOnlyOneDay(List<Exam> sortedExams) {
 		LocalDate beforeDay = null;
 
 		for (Exam exam : sortedExams) {
+			LocalDate examDate = exam.getDueDateTime()
+									 .toLocalDate();
+
 			if (beforeDay == null) {
-				beforeDay = exam.getDueDateTime()
-								.toLocalDate();
+				beforeDay = examDate;
 				continue;
 			}
 
-			if (Math.abs(exam.getDueDateTime()
-							 .toLocalDate()
-							 .until(beforeDay)
-							 .getDays()) != 1) {
+			if (calculateDDay(beforeDay, examDate) != 1) {
 				return false;
 			}
 			beforeDay = exam.getDueDateTime()

diff --git a/...todo/web/policy/util/ExamDateSorting.java → ...owtodo/web/policy/util/DateProcessor.java b/...todo/web/policy/util/ExamDateSorting.java → ...owtodo/web/policy/util/DateProcessor.java
@@ -2,13 +2,14 @@
 
 import java.time.LocalDate;
 import java.time.LocalDateTime;
+import java.time.temporal.ChronoUnit;
 import java.util.List;
 import java.util.stream.Collectors;
 
 import com.codingwasabi.howtodo.web.dailyplan.entity.DailyPlan;
 import com.codingwasabi.howtodo.web.exam.entity.Exam;
 
-public class ExamDateSorting {
+public class DateProcessor {
 	public static List<Exam> sortExams(List<Exam> exams) {
 		return exams.stream()
 					.sorted((e1, e2) -> {
@@ -38,4 +39,8 @@ public static List<DailyPlan> sortDailyPlans(List<DailyPlan> dailyPlans) {
 						 })
 						 .collect(Collectors.toList());
 	}
+
+	public static int calculateDDay(LocalDate start, LocalDate end) {
+		return (int)ChronoUnit.DAYS.between(start, end);
+	}
 }