-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Uno Todo Sample App #137
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
This would close #83 |
I take it you want to wait until refresh is working before converting to a real PR? |
Yes, but though I've stared at it I'm not sure why the refresh isn't working properly and was hoping perhaps someone who knows the tool better could take a look. |
It looks like it's a bug in the WinUI sample. The data is correct, but the VisualState of the checkbox does not always match the IsComplete property. |
src/CommunityToolkit.Datasync.Client/Paging/ConcurrentObservableCollection.cs
Outdated
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
cd5511f
to
dba2ed1
Compare
You'll notice I added a TodoItemViewModel to both the Uno sample and WinUI sample. This was to fix the UI binding issue where the UI wouldn't get PropertyChanged events when the data was edited on another client and then refreshed. Perhaps there was a more simple solution, but this works. |
64487a9
to
df41a3b
Compare
PR is cleaned up and only includes changes related to the Uno sample. Ready for another review. |
TODO:
Bugs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See TODO list in comments.
src/CommunityToolkit.Datasync.Client/Paging/ConcurrentObservableCollection.cs
Outdated
Show resolved
Hide resolved
df41a3b
to
ec89951
Compare
ec89951
to
b718e55
Compare
This is close to functional, but there's problems refreshing.
I started up the WinUI sample and my Uno sample and then pointed them to the sample server running locally.
On startup, both applications would get the list of todos with the correct versions. But as I made changes, some changes would sync but others wouldn't.
It seems to be an issue on the client side, because when I used swagger to check what the server returned, it was correct.
What could be the issue? Could you take a look?
There's this issue, some cleanup and the behaviors need to be added, but then the sample should be ready.