Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Uno Todo Sample App #137

Closed

Conversation

trydalch
Copy link

@trydalch trydalch commented Nov 12, 2024

This is close to functional, but there's problems refreshing.

I started up the WinUI sample and my Uno sample and then pointed them to the sample server running locally.

On startup, both applications would get the list of todos with the correct versions. But as I made changes, some changes would sync but others wouldn't.

It seems to be an issue on the client side, because when I used swagger to check what the server returned, it was correct.

What could be the issue? Could you take a look?

There's this issue, some cleanup and the behaviors need to be added, but then the sample should be ready.

@trydalch

This comment was marked as off-topic.

@trydalch
Copy link
Author

This would close #83

@adrianhall
Copy link
Collaborator

I take it you want to wait until refresh is working before converting to a real PR?

@trydalch
Copy link
Author

Yes, but though I've stared at it I'm not sure why the refresh isn't working properly and was hoping perhaps someone who knows the tool better could take a look.

@trydalch
Copy link
Author

It looks like it's a bug in the WinUI sample. The data is correct, but the VisualState of the checkbox does not always match the IsComplete property.

@trydalch trydalch marked this pull request as ready for review November 21, 2024 22:46
@trydalch

This comment was marked as outdated.

@trydalch trydalch force-pushed the feat/add-uno-todo-sample branch 2 times, most recently from cd5511f to dba2ed1 Compare November 21, 2024 23:07
@trydalch
Copy link
Author

trydalch commented Nov 22, 2024

You'll notice I added a TodoItemViewModel to both the Uno sample and WinUI sample. This was to fix the UI binding issue where the UI wouldn't get PropertyChanged events when the data was edited on another client and then refreshed. Perhaps there was a more simple solution, but this works.

@adrianhall adrianhall added Examples Awaiting Response Awaiting response from the OP labels Nov 22, 2024
@trydalch trydalch changed the title Feat/add uno todo sample Add Uno Todo Sample App Nov 22, 2024
@trydalch trydalch force-pushed the feat/add-uno-todo-sample branch 2 times, most recently from 64487a9 to df41a3b Compare November 22, 2024 18:47
@trydalch
Copy link
Author

PR is cleaned up and only includes changes related to the Uno sample. Ready for another review.

@adrianhall adrianhall self-requested a review November 22, 2024 21:38
@adrianhall
Copy link
Collaborator

TODO:

  • Remove the change to ObservableConcurrentCollection - it's incorporated into the latest client code.
  • Remove identifying information from ApplicationPublisher in csproj
  • Minimize the number of lements in UnoFeatures to only those required by the app
  • Replace Endpoint with https://YOURSITE.azurewebsites.net/ (same as all the other samples)
  • Update NuGet packages to non-vulnerable versions

Bugs:

  • On running (with the service integrated), I get COMException in line 31 of TodoListPge

Copy link
Collaborator

@adrianhall adrianhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See TODO list in comments.

@github-actions github-actions bot added the stale Stale issue or PR. label Nov 29, 2024
@github-actions github-actions bot closed this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Response Awaiting response from the OP Examples stale Stale issue or PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants