Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1 contract state #125

Merged
merged 6 commits into from
Mar 17, 2022
Merged

V1 contract state #125

merged 6 commits into from
Mar 17, 2022

Conversation

abizjak
Copy link
Contributor

@abizjak abizjak commented Feb 6, 2022 •
edited
Loading

Purpose

Minor auxiliary definitions related to V1 contract state.

In support of Concordium/concordium-node#243

Changes

The main change is the addition of InstanceInfo type that is meant to be used as a response in GetInstanceInfo query.
The rest is boilerplate code.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

@abizjak abizjak mentioned this pull request Feb 6, 2022
Merged
8 tasks
@abizjak abizjak marked this pull request as ready for review March 13, 2022 20:25
Bargsteen
Bargsteen approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@Bargsteen Bargsteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

MilkywayPirate
MilkywayPirate approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@MilkywayPirate MilkywayPirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abizjak abizjak merged commit 9f73cfd into main Mar 17, 2022
@abizjak abizjak deleted the v1-contract-state branch March 17, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MilkywayPirate MilkywayPirate MilkywayPirate approved these changes

@Bargsteen Bargsteen Bargsteen approved these changes

@td202 td202 Awaiting requested review from td202

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abizjak @Bargsteen @MilkywayPirate