Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove command transactionSignAndSubmit #308

Merged
merged 3 commits into from
May 28, 2024
Merged

Remove command transactionSignAndSubmit #308

merged 3 commits into from
May 28, 2024

Conversation

DOBEN
Copy link
Member

@DOBEN DOBEN commented May 27, 2024 •
edited
Loading

Purpose

closes #306

Changes

Remove command transaction sign-and-submit
Remove command raw send-transaction

@DOBEN DOBEN requested review from td202 and eb-concordium May 27, 2024 16:14
td202
td202 approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@td202 td202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but I think perhaps we should also remove the legacy raw SendTransaction command that does the same thing. Then we can remove a bunch of the code that supports these (processTransaction, TransactionJSON, TransactionJSONPayload, etc.).

td202
td202 approved these changes May 28, 2024
View reviewed changes
src/Concordium/Client/Types/Transaction.hs Outdated Show resolved Hide resolved
@DOBEN DOBEN merged commit 5461802 into main May 28, 2024
2 checks passed
@DOBEN DOBEN deleted the remove-sign-and-submit branch May 28, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eb-concordium eb-concordium eb-concordium approved these changes

@td202 td202 td202 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove signAndSubmit command in concordium-client
3 participants
@DOBEN @td202 @eb-concordium